feat: use papm instead of apm #402
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
commented
Jun 26, 2022
There was a problem hiding this comment.
The failure is due to tree-sitter. Not sure why pnpm is also installing those for only installing papm
.../node_modules/tree-sitter install: make: Entering directory '/home/vsts/work/1/s/node_modules/.pnpm/github.com+DeeDeeG+node-tree-sitter@bb298eaae66e0c_633c9cfccc090bdf5cdf71b8c45226ac/node_modules/tree-sitter/build'
.../node_modules/tree-sitter install: make: *** No rule to make target 'Release/obj.target/tree_sitter/vendor/tree-sitter/lib/src/lib.o', needed by 'Release/obj.target/tree_sitter.a'. Stop.
.../node_modules/tree-sitter install: make: Leaving directory '/home/vsts/work/1/s/node_modules/.pnpm/github.com+DeeDeeG+node-tree-sitter@bb298eaae66e0c_633c9cfccc090bdf5cdf71b8c45226ac/node_modules/tree-sitter/build'
.../node_modules/tree-sitter install: gyp ERR! build error
.../node_modules/tree-sitter install: gyp ERR! stack Error: `make` failed with exit code: 2
.../node_modules/tree-sitter install: gyp ERR! stack at ChildProcess.onExit (/opt/hostedtoolcache/node/12.18.3/x64/lib/node_modules/pnpm/dist/node_modules/node-gyp/lib/build.js:194:23)
.../node_modules/tree-sitter install: gyp ERR! stack at ChildProcess.emit (events.js:315:20)
.../node_modules/tree-sitter install: gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
.../node_modules/tree-sitter install: gyp ERR! System Linux 5.4.0-1085-azure
.../node_modules/tree-sitter install: gyp ERR! command "/opt/hostedtoolcache/node/12.18.3/x64/bin/node" "/opt/hostedtoolcache/node/12.18.3/x64/lib/node_modules/pnpm/dist/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
.../node_modules/tree-sitter install: gyp ERR! cwd /home/vsts/work/1/s/node_modules/.pnpm/github.com+DeeDeeG+node-tree-sitter@bb298eaae66e0c_633c9cfccc090bdf5cdf71b8c45226ac/node_modules/tree-sitter
.../node_modules/tree-sitter install: gyp ERR! node -v v12.18.3
.../node_modules/tree-sitter install: gyp ERR! node-gyp -v v8.4.1
.../node_modules/tree-sitter install: gyp ERR! not ok
.../node_modules/tree-sitter install: Failed
|
Oh, OK. It was because of |
Github doesn't include the built files
|
I think pnpm does not install git submodules when fetching packages specified as git URLs. That's why it's having trouble installing |
|
Requested a release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/atom-community/papm/releases/tag/v0.1.0