Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Condition Matcher for displaying notifications #5093

Draft
wants to merge 2 commits into
base: feature/ideNotifs
Choose a base branch
from

Conversation

manodnyab
Copy link
Contributor

Description

  1. Deserializer for notifications
  2. Rule engine for matching notifications
    TODO: Adding tests

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@manodnyab manodnyab requested a review from a team as a code owner November 15, 2024 21:54
@manodnyab manodnyab marked this pull request as draft November 15, 2024 21:55
Copy link

Qodana Community for JVM

7 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 3
Const property naming convention ◽️ Notice 3
Class member can have 'private' visibility ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

import com.intellij.openapi.project.Project
import software.aws.toolkits.jetbrains.utils.notifySticky

object DisplayToastNotifications {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Object "DisplayToastNotifications" is never used
notifySticky(notifyType, title, message, null, action)
}

fun shouldShow(project: Project, notificationData: NotificationData) {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Function "shouldShow" is never used
return shouldShow
}

fun matchesAllRules(notificationConditions: NotificationDisplayCondition, project: Project): Boolean {

Check notice

Code scanning / QDJVMC

Class member can have 'private' visibility Note

Function 'matchesAllRules' could be private
return SystemDetails(computeType, computeArchitecture, osType, osVersion, ideType, ideVersion, pluginVersionMap)
}

data class AuthDetails(

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "AuthDetails" is never used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant