-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.15 Release Notes: Set
Reflection
#1805
base: main
Are you sure you want to change the base?
Conversation
pub struct Person; | ||
|
||
#[derive(Component, Reflect)] | ||
pub struct Friendships(EntityHashSet<Entity>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EntityHashSet is not generic. Perhaps it would be better to make this HashSet<Entity>
, rather than using our built in / special cased EntityHashSet
, just for simplicity?
to see the contents of your `HashSet`s. This enhancement allows for deeper | ||
introspection and easier debugging in your game development workflow. | ||
|
||
Here is an example of entity connections where this improvement will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how others feel about this but I feel like we should be highlighting the new features provided by Set
rather than explain how it will affect a single crate (not that we can't mention 3rd party crates, just that I don't think it should be the main focus)
Here is an example of entity connections where this improvement will be | ||
helpful: | ||
|
||
```rust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: This example might be better served showcasing how Set
works, maybe even comparing it to Map
.
Or perhaps if we do want to use bevy-inspector-egui here, maybe we could show a screenshot of this in action?
Write the section mentioned in #1665