GRPC jwt based call authentication #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanwen
changed the title
bsideup
reviewed
Feb 6, 2020
| @Test | ||
| void shouldAddWithHmac512() { | ||
| applicationContextRunner = applicationContextRunner.withPropertyValues( | ||
| "spring.profiles.active: not_gateway", |
There was a problem hiding this comment.
should I require gateway profile? I would expect that it wouldn't be a situation when grpc.auth has some setup, but grpc itself is disabled. That's why I simplified this config and left it independently from the anything else.
bsideup
reviewed
Feb 6, 2020
...sport-auth/src/main/java/com/github/bsideup/liiklus/transport/grpc/StaticRSAKeyProvider.java
Show resolved
Hide resolved
bsideup
reviewed
Feb 6, 2020
bsideup
reviewed
Feb 6, 2020
bsideup
reviewed
Feb 6, 2020
|
blocked now by #259 |
lanwen
commented
Feb 7, 2020
gradle.properties
Outdated
| @@ -1 +1,2 @@ | |||
| org.gradle.caching=true | |||
| version=0.0.1-SNAPSHOT | |||
There was a problem hiding this comment.
had to define it, otherwise pf4j complained for a unparseable version during plugins startup (seems plugin dependency triggered that parsing, even there is no version specified there)
bsideup
reviewed
Feb 7, 2020
bsideup
reviewed
Feb 7, 2020
bsideup
reviewed
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #188
Channel auth would follow as a separate PR