Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test to replicate issue #4621 #4741

Closed
wants to merge 7 commits into from

Conversation

nebojsasandin
Copy link

Modified Google test to replicate this issue: #4621

@AppVeyorBot
Copy link

@amaitland
Copy link
Member

  • Please fix the formatting (you've reformatted the whole file).
  • Please create a new test for the issue rather than rewriting an existing one (we still need to keep the existing one).

Add files via upload

It appears you've uploaded the file which makes me wonder if you've actually run the test?

@AppVeyorBot
Copy link

# Conflicts:
#	CefSharp.Test/OffScreen/OffScreenBrowserTests.cs
Formatted and rewritten OffScreenBrowserTests.cs to include a new test which mimics this issue: cefsharp#4741
@nebojsasandin
Copy link
Author

@amaitland
Is it better now?

  • Previously you've given me a direct line to a Google test method, made me think you wanted me to include this Google-related issue into that test. Forgive my foolishness.
  • I have created a new test, and ran it, it still produces the same issue previously stated.
  • Originally I could not run any tests on my end, when I compiled the code I got a whole bunch of C++ errors I'm unfamiliar with, and I could not work out how to make it run, so I just changed the test I needed to. Then I got error 403 - Forbidden when I tried to commit from my computer, so I simply uploaded the file via git web. I did not think it would mess up the entire file formatting. Sorry about that. Desktop git is working now, and the entire source is compiling properly, so I was able to do both: run the test locally, and commit changes properly.
  • Let me know if there's anything else you need from me.

@AppVeyorBot
Copy link

@amaitland amaitland changed the title Modified Google test to replicate this issue: https://github.com/cefsharp/CefSharp/issues/4621 Add Test to replicate issue #4621 Mar 9, 2024
@amaitland
Copy link
Member

Thanks. I'll have a look closer on the weekend.

@amaitland
Copy link
Member

The issue does indeed look like an upstream one. If you isolate the two origins in different render processes then it should work as expected.

settings.CefCommandLineArgs.Add("isolate-origins", "https://www.google.com,https://accounts.google.com/");

@amaitland
Copy link
Member

I've manually merged this test in commit 800cbcf

It's now in a separate file that references the original issue.

Thanks for the unit tests 👍

@amaitland amaitland closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants