-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Test to replicate issue #4621 #4741
Conversation
Modified Google test to replicate this issue: cefsharp#4621
❌ Build CefSharp 122.1.90-CI4947 failed (commit 9c52d1fb58 by @nebojsasandin) |
It appears you've uploaded the file which makes me wonder if you've actually run the test? |
❌ Build CefSharp 122.1.90-CI4951 failed (commit 1b9003a122 by @amaitland) |
# Conflicts: # CefSharp.Test/OffScreen/OffScreenBrowserTests.cs
Formatted and rewritten OffScreenBrowserTests.cs to include a new test which mimics this issue: cefsharp#4741
@amaitland
|
❌ Build CefSharp 122.1.90-CI4953 failed (commit 1aeeb9b9ce by @nebojsasandin) |
Thanks. I'll have a look closer on the weekend. |
The issue does indeed look like an settings.CefCommandLineArgs.Add("isolate-origins", "https://www.google.com,https://accounts.google.com/"); |
I've manually merged this test in commit 800cbcf It's now in a separate file that references the original issue. Thanks for the unit tests 👍 |
Modified Google test to replicate this issue: #4621