remove idt & idt_reg #182
Open
remove idt & idt_reg #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"idt.h" included by idt.c and kernel.c, which will cause link failed. so move the definition of idt to idt.c to avoid the failure below. ld: cpu/idt.o:(.bss+0x0): multiple definition of `idt'; kernel/kernel.o:(.bss+0x0): first defined here ld: cpu/idt.o:(.bss+0x800): multiple definition of `idt_reg'; kernel/kernel.o:(.bss+0x800): first defined here ld: cpu/isr.o:(.bss+0x0): multiple definition of `idt'; kernel/kernel.o:(.bss+0x0): first defined here ld: cpu/isr.o:(.bss+0x800): multiple definition of `idt_reg'; kernel/kernel.o:(.bss+0x800): first defined here
zdychacek
reviewed
Nov 18, 2020
| @@ -27,10 +27,6 @@ typedef struct { | |||
| u32 base; | |||
| } __attribute__((packed)) idt_register_t; | |||
|
|
|||
| #define IDT_ENTRIES 256 | |||
There was a problem hiding this comment.
This pull request does not contain change of moving deleted code into c file.
There was a problem hiding this comment.
Ok, I see your changes spreaded into multiple pull requests (https://github.com/cfenollosa/os-tutorial/pull/181/files).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"idt.h" included by idt.c and kernel.c, which will cause link failed. so move the definition of idt to idt.c to avoid the failure below.
ld: cpu/idt.o:(.bss+0x0): multiple definition of
idt'; kernel/kernel.o:(.bss+0x0): first defined here ld: cpu/idt.o:(.bss+0x800): multiple definition ofidt_reg'; kernel/kernel.o:(.bss+0x800): first defined hereld: cpu/isr.o:(.bss+0x0): multiple definition of
idt'; kernel/kernel.o:(.bss+0x0): first defined here ld: cpu/isr.o:(.bss+0x800): multiple definition ofidt_reg'; kernel/kernel.o:(.bss+0x800): first defined here