Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps and resolve #881

Merged
merged 4 commits into from
Mar 3, 2022
Merged

chore: update deps and resolve #881

merged 4 commits into from
Mar 3, 2022

Conversation

jinlee93
Copy link
Contributor

@jinlee93 jinlee93 commented Mar 2, 2022

Summary:

  • update storybook, plop

Test Plan:

  • storybook, plop, watch commands work

@jinlee93 jinlee93 requested a review from a team March 2, 2022 04:59
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size-limit report

Path Size
components 71.99 KB (0%)
styles 4.47 KB (0%)

Copy link
Contributor

@anniehu4 anniehu4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these are fixing vulnerabilities, could you link them in the PR summary? thanks!

package.json Outdated
"prettier": "^2.5.1",
"size-limit": "^4.12.0",
"stylelint": "^14.5.3",
"stylelint-config-standard": "^25.0.0",
"typescript": "^4.5.5"
},
"resolutions": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL!

@jinlee93
Copy link
Contributor Author

jinlee93 commented Mar 2, 2022

if these are fixing vulnerabilities, could you link them in the PR summary? thanks!

Yup, will do

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #881 (7884ec5) into main (dba4d21) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files         142      142           
  Lines        1128     1128           
  Branches      171      171           
=======================================
  Hits         1081     1081           
  Misses         46       46           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba4d21...7884ec5. Read the comment docs.

@jinlee93
Copy link
Contributor Author

jinlee93 commented Mar 2, 2022

if these are fixing vulnerabilities, could you link them in the PR summary? thanks!

Yup, will do

After discussion with Andrew, will be dropping the resolutions. Since dev use only, should have minimal risk and is not worth resolving for.

A somewhat related consideration could be using chokidar-cli over watch as it seems to be a little more supported. However, didn't include as part of this pr since there it brings its own vulnerabilities

@jinlee93 jinlee93 merged commit c48915f into main Mar 3, 2022
@jinlee93 jinlee93 deleted the jlee/updates branch March 3, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants