-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps and resolve #881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size-limit report
Path | Size |
---|---|
components | 71.99 KB (0%) |
styles | 4.47 KB (0%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if these are fixing vulnerabilities, could you link them in the PR summary? thanks!
package.json
Outdated
"prettier": "^2.5.1", | ||
"size-limit": "^4.12.0", | ||
"stylelint": "^14.5.3", | ||
"stylelint-config-standard": "^25.0.0", | ||
"typescript": "^4.5.5" | ||
}, | ||
"resolutions": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL!
Yup, will do |
Codecov Report
@@ Coverage Diff @@
## main #881 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 142 142
Lines 1128 1128
Branches 171 171
=======================================
Hits 1081 1081
Misses 46 46
Partials 1 1 Continue to review full report at Codecov.
|
After discussion with Andrew, will be dropping the resolutions. Since dev use only, should have minimal risk and is not worth resolving for. A somewhat related consideration could be using |
Summary:
Test Plan: