Use cbor-edn instead of cbor-diag #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that conversions such as from |
This fixes small bugs around wrong encoding indicators, updates to edn-literals' more precise encoding indicators, and enables future extensions like application oriented literals.
All known AOLs are decoded from diag to cbor; from cbor to diag, this is only applied in pretty mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that cbor-diag development has stalled, while new features are coming to EDN, which cbor-edn (for context: which I am maintaining) does support by virtue of being built on the current edn-literals draft's ABNF.
This is a compatible change in that it preserves the API; any difference in behavior exceeding the amount of prettiness applied (in particular, indenting differs -- but that was announced to be volatile) would be due to a bug in either of the back-end libraries.
cbor-edn offers quite a few knobs in conversion; these are initially not shown and all hidden behind pretty (applying whatever is available) vs. non-pretty (doing the baseline).