Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some temporary directory handling changes #94

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Some temporary directory handling changes #94

wants to merge 2 commits into from

Commits on Apr 29, 2024

  1. canonicalize temp sandbox directory everywhere 

    We currently only canonicalize the temp sandbox directory on macOS,
which is critical since `/tmp` is really `/private/tmp`. However, we
should do it everywhere, so that tests can actually expect a consistent
outcome by looking at `clar_sandbox_path()`.
    @ethomson
    ethomson committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3b35aff View commit details
    Browse the repository at this point in the history

  2. tempdir and sandboxes are now separate entities 

    clar now has the concept of a _temporary directory_, which is the
temporary directory for the entirety of a `clar` invocation (a set of
test runs) and a sandbox, which is the temporary directory for a single
test invocation.

This allows us to ensure that a well-written test (that only writes into
its sandbox) doesn't poison the well for future test invocations if it
fails to clean up its sandbox.
    @ethomson
    ethomson committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    ca684b9 View commit details
    Browse the repository at this point in the history