-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fix time-purity by introducing Instant
parameters
#417
Open
thomaseizinger
wants to merge
24
commits into
cloudflare:master
Choose a base branch
from
firezone:feat/fix-time-impurity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: fix time-purity by introducing Instant
parameters
#417
thomaseizinger
wants to merge
24
commits into
cloudflare:master
from
firezone:feat/fix-time-impurity
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaseizinger
force-pushed
the
feat/fix-time-impurity
branch
from
October 22, 2024 04:09
28ececf
to
452f8e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its current implementation,
boringtun
is impure w.r.t. time because it callsInstant::now
andInstant::elapsed
internally. To test time-related functionality, themock-instant
dependency is currently used.This is unnecessary and can also be solved by introducing
Instant
parameters to all necessary functions.This PR does that in a fully-backwards compatible way by introducing
_at
functions for all necessary public functions that require the current time.Resolves: #391.