Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass options using postMessage: DO NOT MERGE #440

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stephen-pope-customer-io
Copy link
Contributor

@stephen-pope-customer-io stephen-pope-customer-io commented Sep 23, 2024

The idea here is to support passing the options data to the gist-web-renderer using postMessage instead of passing it as a url parameter.

Required: gist-web-renderer PR here: https://github.com/customerio/gist-web-renderer/pull/17

This is currently working in a similar gist-web PR here: customerio/gist-web#66

Linear issue: https://linear.app/customerio/issue/INAPP-12777/request-header-too-large-preventing-in-app-messages-from-rendering

This is work in progress. Currently on my machine with the gist-web-renderer PR I get this in my logs, which I believe is a CORS issue.

JavaScript injected for postMessage
Flutter Web Bootstrap: Auto. -- From line 7380 of http://192.168.2.86:8080/web/main.dart.js Message received base -- From line 1 of http://192.168.2.86:8080/web/main.min.js Message received json: {"isTrusted":true} -- From line 1 of http://192.168.2.86:8080/web/main.min.js Message received orig: [object Object] -- From line 1 of http://192.168.2.86:8080/web/main.min.js Options received: {"dataCenter":"us","endpoint":"https://engine.api.dev.gist.build","instanceId":"77140a57-2e78-446a-a504-b89fefa10e80","livePreview":false,"messageId":"gist-html-01J87SG3MHFFVP758GX91CFJBR","properties":{"gist":{"encodedMessageHtml":"H4sIAAAAAAAA/7x625LjyHHo+35FLjeknVEMk3W/sJujWFFHp+0YyQrL2w/7okCTRRJqEKABsC/bMV/gJ3+Bf9Gf4MgCCiDZM5IVIXfPRDezMivvmZVF4BuA62/X1ap9PgTYtfviI63QByiycruYHMv1BNZ5vZhkx7aaEJoIQrbuPgJc70ObwWqX1U1oF5Nju5m6CcwG9LfTKfxrWFX7fSjXYQ0PeXg8VHULbQWhbI51gLycZodDA80qKwIc6uoQ6uIZslVdNQ2sw0O+Cg1Mp2ci+88AZbYPi0liOxnWV1XZhrJdTB7zdbtbdGymEfgAeZm3eVZMo8gFR/YB9tlTvj/uT5eOTagjnN0VYcES79m57Z0Cq6qoiHgX9mEyCi+rep8Vpw5p87YIH69n3d+02rTPIwQwr6uqhZcBJnNG/nPo2F4N+M/fDB9j9E53Vg+hblZ1VRTTu7DLHvKqJgZluILZr85is6lq2Fd3eRHIdIrQoQ4PoWxhG5r2WIcGNnW1h331kJdbaHcpdlBtNtCs6hBK+NXsVOtj3ZC4ddhkx6I9VTh9uqvWz2f6bqqynW6yfV48z+GHOs+KD9BkZTNtQp1vrk4o91m9zcs5sNPF6WO4u8/baWTT7Kuq3eXldg5ZSRHPsyasz8j31c/Tqnl6Rb+ts+eYC6+Vvp6dhKsPHa7E/Zbd5S9FXobpLuTbXTvnqK9OzbkJxUNo81X24cSgz7hqd6tQ3L8csvWaZLvDE60e7DF/rF/22VOXtnOqwavO6GkRNu3ZQh0lxpWYK/PvTPz5sgJXl2om2UIdnoB+XVHebIrqseN5l63ut3V1LNfz7zaB/l3dVfU61NM6W+fHJip9Vz1Nm122rh7nDMThCYgZg3p7l71jH6D/j/x9R5n/TBJ7NndVNHqb1T9nxUtvgow/nQlN/nOYCxJzrrvQvQvmrPMbv1emNmq+IwteThVnTJmMwbf5nnpFVrZEnpdeZ/KlT9VDlZdtqK/WeXMosud5XkZpd0W1ur/qwsAZ+8VXDBhjFYl6K34Xf74SiNE2bg5PHfjY2WYZu2rDUztt66xsNlW9n8e6jWtZkW/L+SpEbePKOqyqOmvzquzITt2Ul7tQ5+0QZu4oMhSyM/dou1Iprp0dkeZVoD/jSptjUz2+vNalD0YUQITmvtzxl+TPTRGerv5ybNp88zzt22TaGdlM8zbsm7SUokxC+0Rvq0Pnqh6+q9q22s+nvV5RHBxSBmU8E3fi1MviwsuKsfOMOpHVFZU65YxZudpV9fSxzg6HUJ8b9gULvhiaTrkUlJF3UW2r6JUsL0P9ss0OUfjfkvE1BlBkd6H4v3PFhbTmYfvyEGpK66LPiX2+XhdhCKPotj9u/vIs/v3lizXWJducXa2K/DCvw6p9xw9PH+Ds1/urvssT0fSQtbt5XjahfafZL95ffXExqXDa2Xb5eh3KlLFTwqUCYVeHqsljxLK7piqObUjlf3i6etzlbZg2h2wV5mVFqXD1OZ0K17NxPrqOpxsMx/w6f4BVkTXNYtKfF/CUMmkC4/n/Tfx/Rt6dEYmox6bPr36lXd0ZMhkRH8ePI32c+vhXWHQd+ZTFf//Xf/4H3IRnmgDq8O31bMdHrQ5f1amj+bddVt7Dc3WM48ZqV1UNDRPVsabRb31ctQg32UOADIqquocsNieaz+4DbaubUGwga3sTdtU+QFauId9EpmUIa8jKZ8iaJm/arFyFD3AoQtYEKEILxwbuy+oRSdXZ4cyZg8Vda0uuvr47tm1V9vJoVF5MuqU0EFblqshX94vJPjRNtg24zpt93jTvXj6/n5y6enRqd+hAOqvOqFIaLKuyzctj6LSYdTLjhD5b5w+9cpuqakM98I2FOemn91D2w3vR1ml2zxLpeRubwK4Om8Vk17aHZj6brY5Ni3k1k8/h53+um8mQwYePvw1Nvi2jl9ewDkX+EOqwhse83Q0ePXfoeZuYjGl+3RyyctC96woT+Lg8Nm21DzXm1fWMSE53PGxPpjca+39TPS0mDBh4pYALPzmdJfOioCG8DKerT/uibDpb57PZ4+MjPkqs6u1MMMZmzcN2JP54su16C0NnWUyOdfHuO4LZn720f+bu/eSUmG4HWXN/tgKQrxcTWk57Jhf42EE6kill2hyK4z4vKYsvSYnmxzJvm8WE7il/ol70L+WPzStC8s7l2vMX1rp70sQrdYnpWudicuHcc+9Ek8k1sF5Mfk+xYDfslgt/45W6ZT9N+mDE1nlyIep3zsiei7VtNLJ39anbLl39ZWeP7uZfcfff5fC/w+XR6eL16vNiMuWvlwfPv4rJie/lq42XPuj9/2oV+ohwtFbClKGQXjNxI1AIIwXFiJZueorbgeKn1+rAWRRfoWev4vKFuH4psvyrkf0bVmmUSnDQyLTX9sYoFEKpW2mQWeU+JbyxyJwXn3o8eIdCSDPa3tF94sKgVHzAX/Lp5fwVz3z3A/9B/OYLwX/lm79umXJonRIgGGpm7ScpUQitBktT9JKG3KIxRoHmaBQXA/2l5Yn+gv8bWJQ0dAKNNuZTb0HvazfEotd80JBzicZexs5dWDh6oOf/BhY5zZF7dVJTTgrkt9yh01ze9Pj/VUX9o3QSXKB0EpREJqxZCsHQOZ9gEMKhYByUQ84kByEZCs9BG1RG3QjlUSixFMoi1wKkQ+OtBCE5SqlBGPRMcCAxWqoEL7lnaJUd8NwKNJ6TWG7NCBuDnmu5TLDnaLxzQPu5Bs4sGqsieyEHeJm0HPDKoGIWvEEjjIFebbAWvZH+pqdfCmHRMwnOoLXcA3nDqihWayah85ZK8FIwhs4PMHBPeAeOo1BOD/BgRg9rgc5xoO3a69HZ58F4g/BLZtA4B5aj9EouE+wUescNCO+RWUsGCi0kCM/QDeBSOI7WuBFtNVrvwGnkkvEBtgqZE+pWUHooeSO0Qa3crbUouOXLHgZvUVrKMuOQU5hj/DQIp9CQfzt4KbxCOcIgmUDKIqaQeQGSWeTSULi90OKWM4NMyhspNFrnBzV6a29769+iBXCFnJqORme5vLFeIjd+0LDH3/b4tzg4vETGxspUlqGh1O8rU2mBwmhQArX1ZoBTSifYc/TeCaD9Uoyll/in0tRcxxJKeC0l6pPKTnDin2AlUDjGgfbrk85yof9Pg0GpRpVjqIwfalRZjt5QiWplEzRY04FaoJVcA+2V3A0FmninbqkZGWMHvOYSnRepvhM42NLDjmw1GtL2QbVz1d8g+kYKqrgh+kZwNMIN3jXUkajAOEonwLC+zXu0SvKloboTFiSjs1eDpnQWZtiunUImxuTSVqKzJ3ij0RvX75egDY/zlLToGE/9gt9oJWKhdmUibojOen5rJDKpxLKHQXlqxw608ahYPE6k0A60tWiYS/BSU31xNeK9QGY9nXJOMzXAhiFTo1jDOXInBrE9DJrIlAXDHVovBraG7PSjWCM1CqZHvOKorB7EJvhSrGFohbrVlEZi2YMgNXKuDBhlUanRqRcxfYMssszFmh+yyFm0J2lgjENr9VDDCTYGrTF2mWAvyBAOtJ8LP/QIyzwyM/YQKzQ5ZsQrjtpb4Iyh1B6sMigtOIlSOntjhUVtl1ZI9B48Q8EMWG7QiShTe2WjDGN4gpfGOzRCDHjjCJ9ORjDO0aQCljqF4zeWBiDubo1Dra1Z9jAojsyRSjStsrGtXrjsp98TQyaohJBrbpckT5qYkkILDcZbdNRPOTopZWTAhEjw0lLuGTvihUEtFO23jGkgJyjuE/+bXt5bnHlMIBMGlEHDWSxqrbRZOsbQODrcUSgjwHqHV Loading message -- From line 1 of http://192.168.2.86:8080/web/main.min.js organizationId: undefined -- From line 1 of http://192.168.2.86:8080/web/main.min.js Message global timeout, cancelling display.
GistView Error loading engine
Store: action: MessageLoadingFailed(message=Message(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, instanceId=77140a57-2e78-446a-a504-b89fefa10e80, priority=10, queueId=01e0fb5e-7117-481d-a204-d786d0669348, properties=GistProperties(routeRule=null, elementId=null, campaignId=null, position=CENTER, persistent=false)) Store: state before reducer: InAppMessagingState(siteId='0f4234d28520fd1619d0', dataCenter='us',
environment=DEV,
pollInterval=10000,
userId=[email protected],
currentRoute=Dashboard,
currentMessageState=Loading(message=Message(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, instanceId=77140a57-2e78-446a-a504-b89fefa10e80, priority=10, queueId=01e0fb5e-7117-481d-a204-d786d0669348, properties=GistProperties(routeRule=null, elementId=null, campaignId=null, position=CENTER, persistent=false)), messagesInQueue=[01e0fb5e-7117-481d-a204-d786d0669348], shownMessageQueueIds=[])
Error occurred on message: Message(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, instanceId=77140a57-2e78-446a-a504-b89fefa10e80, priority=10, queueId=01e0fb5e-7117-481d-a204-d786d0669348, properties=GistProperties(routeRule=null, elementId=null, campaignId=null, position=CENTER, persistent=false) in-app message: errorWithMessage. message: InAppMessage(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, queueId=01e0fb5e-7117-481d-a204-d786d0669348, deliveryId=null) track an event with name in-app message action and attributes {delivery-id=NULL, event-name=errorWithMessage, message-id=gist-html-01J87SG3MHFFVP758GX91CFJBR} JavaScript injected for postMessage
Access to XMLHttpRequest at 'https://engine-consumer-api.cloud.dev.gist.build/api/v2/configuration?cioSiteId=0f4234d28520fd1619d0&cioDatacenter=us&random=0' from origin 'http://192.168.2.86:8080' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. -- From line 0 of http://192.168.2.86:8080/web/index.html#/ Uncaught -- From line 6090 of http://192.168.2.86:8080/web/main.dart.js

Complete each step to get your pull request merged in. Learn more about the workflow this project uses.

  • Assign members of your team to review the pull request.
  • Wait for pull request status checks to complete. If there are problems, fix them until you see that all status checks are passing.
  • Wait until the pull request has been reviewed and approved by a teammate
  • After pull request is approved, and you determine it's ready add the label "Ready to merge" to the pull request and it will automatically be merged.

Linear issue: https://linear.app/customerio/issue/INAPP-12777/request-header-too-large-preventing-in-app-messages-from-rendering

This is work in progress. Currently on my machine with the gist-web-renderer PR I get this in my logs:

JavaScript injected for postMessage
Flutter Web Bootstrap: Auto. -- From line 7380 of http://192.168.2.86:8080/web/main.dart.js
Message received base -- From line 1 of http://192.168.2.86:8080/web/main.min.js
Message received json: {"isTrusted":true} -- From line 1 of http://192.168.2.86:8080/web/main.min.js
Message received orig: [object Object] -- From line 1 of http://192.168.2.86:8080/web/main.min.js
Options received: {"dataCenter":"us","endpoint":"https://engine.api.dev.gist.build","instanceId":"77140a57-2e78-446a-a504-b89fefa10e80","livePreview":false,"messageId":"gist-html-01J87SG3MHFFVP758GX91CFJBR","properties":{"gist":{"encodedMessageHtml":"H4sIAAAAAAAA/7x625LjyHHo+35FLjeknVEMk3W/sJujWFFHp+0YyQrL2w/7okCTRRJqEKABsC/bMV/gJ3+Bf9Gf4MgCCiDZM5IVIXfPRDezMivvmZVF4BuA62/X1ap9PgTYtfviI63QByiycruYHMv1BNZ5vZhkx7aaEJoIQrbuPgJc70ObwWqX1U1oF5Nju5m6CcwG9LfTKfxrWFX7fSjXYQ0PeXg8VHULbQWhbI51gLycZodDA80qKwIc6uoQ6uIZslVdNQ2sw0O+Cg1Mp2ci+88AZbYPi0liOxnWV1XZhrJdTB7zdbtbdGymEfgAeZm3eVZMo8gFR/YB9tlTvj/uT5eOTagjnN0VYcES79m57Z0Cq6qoiHgX9mEyCi+rep8Vpw5p87YIH69n3d+02rTPIwQwr6uqhZcBJnNG/nPo2F4N+M/fDB9j9E53Vg+hblZ1VRTTu7DLHvKqJgZluILZr85is6lq2Fd3eRHIdIrQoQ4PoWxhG5r2WIcGNnW1h331kJdbaHcpdlBtNtCs6hBK+NXsVOtj3ZC4ddhkx6I9VTh9uqvWz2f6bqqynW6yfV48z+GHOs+KD9BkZTNtQp1vrk4o91m9zcs5sNPF6WO4u8/baWTT7Kuq3eXldg5ZSRHPsyasz8j31c/Tqnl6Rb+ts+eYC6+Vvp6dhKsPHa7E/Zbd5S9FXobpLuTbXTvnqK9OzbkJxUNo81X24cSgz7hqd6tQ3L8csvWaZLvDE60e7DF/rF/22VOXtnOqwavO6GkRNu3ZQh0lxpWYK/PvTPz5sgJXl2om2UIdnoB+XVHebIrqseN5l63ut3V1LNfz7zaB/l3dVfU61NM6W+fHJip9Vz1Nm122rh7nDMThCYgZg3p7l71jH6D/j/x9R5n/TBJ7NndVNHqb1T9nxUtvgow/nQlN/nOYCxJzrrvQvQvmrPMbv1emNmq+IwteThVnTJmMwbf5nnpFVrZEnpdeZ/KlT9VDlZdtqK/WeXMosud5XkZpd0W1ur/qwsAZ+8VXDBhjFYl6K34Xf74SiNE2bg5PHfjY2WYZu2rDUztt66xsNlW9n8e6jWtZkW/L+SpEbePKOqyqOmvzquzITt2Ul7tQ5+0QZu4oMhSyM/dou1Iprp0dkeZVoD/jSptjUz2+vNalD0YUQITmvtzxl+TPTRGerv5ybNp88zzt22TaGdlM8zbsm7SUokxC+0Rvq0Pnqh6+q9q22s+nvV5RHBxSBmU8E3fi1MviwsuKsfOMOpHVFZU65YxZudpV9fSxzg6HUJ8b9gULvhiaTrkUlJF3UW2r6JUsL0P9ss0OUfjfkvE1BlBkd6H4v3PFhbTmYfvyEGpK66LPiX2+XhdhCKPotj9u/vIs/v3lizXWJducXa2K/DCvw6p9xw9PH+Ds1/urvssT0fSQtbt5XjahfafZL95ffXExqXDa2Xb5eh3KlLFTwqUCYVeHqsljxLK7piqObUjlf3i6etzlbZg2h2wV5mVFqXD1OZ0K17NxPrqOpxsMx/w6f4BVkTXNYtKfF/CUMmkC4/n/Tfx/Rt6dEYmox6bPr36lXd0ZMhkRH8ePI32c+vhXWHQd+ZTFf//Xf/4H3IRnmgDq8O31bMdHrQ5f1amj+bddVt7Dc3WM48ZqV1UNDRPVsabRb31ctQg32UOADIqquocsNieaz+4DbaubUGwga3sTdtU+QFauId9EpmUIa8jKZ8iaJm/arFyFD3AoQtYEKEILxwbuy+oRSdXZ4cyZg8Vda0uuvr47tm1V9vJoVF5MuqU0EFblqshX94vJPjRNtg24zpt93jTvXj6/n5y6enRqd+hAOqvOqFIaLKuyzctj6LSYdTLjhD5b5w+9cpuqakM98I2FOemn91D2w3vR1ml2zxLpeRubwK4Om8Vk17aHZj6brY5Ni3k1k8/h53+um8mQwYePvw1Nvi2jl9ewDkX+EOqwhse83Q0ePXfoeZuYjGl+3RyyctC96woT+Lg8Nm21DzXm1fWMSE53PGxPpjca+39TPS0mDBh4pYALPzmdJfOioCG8DKerT/uibDpb57PZ4+MjPkqs6u1MMMZmzcN2JP54su16C0NnWUyOdfHuO4LZn720f+bu/eSUmG4HWXN/tgKQrxcTWk57Jhf42EE6kill2hyK4z4vKYsvSYnmxzJvm8WE7il/ol70L+WPzStC8s7l2vMX1rp70sQrdYnpWudicuHcc+9Ek8k1sF5Mfk+xYDfslgt/45W6ZT9N+mDE1nlyIep3zsiei7VtNLJ39anbLl39ZWeP7uZfcfff5fC/w+XR6eL16vNiMuWvlwfPv4rJie/lq42XPuj9/2oV+ohwtFbClKGQXjNxI1AIIwXFiJZueorbgeKn1+rAWRRfoWev4vKFuH4psvyrkf0bVmmUSnDQyLTX9sYoFEKpW2mQWeU+JbyxyJwXn3o8eIdCSDPa3tF94sKgVHzAX/Lp5fwVz3z3A/9B/OYLwX/lm79umXJonRIgGGpm7ScpUQitBktT9JKG3KIxRoHmaBQXA/2l5Yn+gv8bWJQ0dAKNNuZTb0HvazfEotd80JBzicZexs5dWDh6oOf/BhY5zZF7dVJTTgrkt9yh01ze9Pj/VUX9o3QSXKB0EpREJqxZCsHQOZ9gEMKhYByUQ84kByEZCs9BG1RG3QjlUSixFMoi1wKkQ+OtBCE5SqlBGPRMcCAxWqoEL7lnaJUd8NwKNJ6TWG7NCBuDnmu5TLDnaLxzQPu5Bs4sGqsieyEHeJm0HPDKoGIWvEEjjIFebbAWvZH+pqdfCmHRMwnOoLXcA3nDqihWayah85ZK8FIwhs4PMHBPeAeOo1BOD/BgRg9rgc5xoO3a69HZ58F4g/BLZtA4B5aj9EouE+wUescNCO+RWUsGCi0kCM/QDeBSOI7WuBFtNVrvwGnkkvEBtgqZE+pWUHooeSO0Qa3crbUouOXLHgZvUVrKMuOQU5hj/DQIp9CQfzt4KbxCOcIgmUDKIqaQeQGSWeTSULi90OKWM4NMyhspNFrnBzV6a29769+iBXCFnJqORme5vLFeIjd+0LDH3/b4tzg4vETGxspUlqGh1O8rU2mBwmhQArX1ZoBTSifYc/TeCaD9Uoyll/in0tRcxxJKeC0l6pPKTnDin2AlUDjGgfbrk85yof9Pg0GpRpVjqIwfalRZjt5QiWplEzRY04FaoJVcA+2V3A0FmninbqkZGWMHvOYSnRepvhM42NLDjmw1GtL2QbVz1d8g+kYKqrgh+kZwNMIN3jXUkajAOEonwLC+zXu0SvKloboTFiSjs1eDpnQWZtiunUImxuTSVqKzJ3ij0RvX75egDY/zlLToGE/9gt9oJWKhdmUibojOen5rJDKpxLKHQXlqxw608ahYPE6k0A60tWiYS/BSU31xNeK9QGY9nXJOMzXAhiFTo1jDOXInBrE9DJrIlAXDHVovBraG7PSjWCM1CqZHvOKorB7EJvhSrGFohbrVlEZi2YMgNXKuDBhlUanRqRcxfYMssszFmh+yyFm0J2lgjENr9VDDCTYGrTF2mWAvyBAOtJ8LP/QIyzwyM/YQKzQ5ZsQrjtpb4Iyh1B6sMigtOIlSOntjhUVtl1ZI9B48Q8EMWG7QiShTe2WjDGN4gpfGOzRCDHjjCJ9ORjDO0aQCljqF4zeWBiDubo1Dra1Z9jAojsyRSjStsrGtXrjsp98TQyaohJBrbpckT5qYkkILDcZbdNRPOTopZWTAhEjw0lLuGTvihUEtFO23jGkgJyjuE/+bXt5bnHlMIBMGlEHDWSxqrbRZOsbQODrcUSgjwHqHV
Loading message -- From line 1 of http://192.168.2.86:8080/web/main.min.js
organizationId: undefined -- From line 1 of http://192.168.2.86:8080/web/main.min.js
Message global timeout, cancelling display.
GistView Error loading engine
Store: action: MessageLoadingFailed(message=Message(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, instanceId=77140a57-2e78-446a-a504-b89fefa10e80, priority=10, queueId=01e0fb5e-7117-481d-a204-d786d0669348, properties=GistProperties(routeRule=null, elementId=null, campaignId=null, position=CENTER, persistent=false))
Store: state before reducer: InAppMessagingState(siteId='0f4234d28520fd1619d0',
dataCenter='us',
environment=DEV,
pollInterval=10000,
[email protected],
currentRoute=Dashboard,
currentMessageState=Loading(message=Message(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, instanceId=77140a57-2e78-446a-a504-b89fefa10e80, priority=10, queueId=01e0fb5e-7117-481d-a204-d786d0669348, properties=GistProperties(routeRule=null, elementId=null, campaignId=null, position=CENTER, persistent=false)),
messagesInQueue=[01e0fb5e-7117-481d-a204-d786d0669348],
shownMessageQueueIds=[])
Error occurred on message: Message(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, instanceId=77140a57-2e78-446a-a504-b89fefa10e80, priority=10, queueId=01e0fb5e-7117-481d-a204-d786d0669348, properties=GistProperties(routeRule=null, elementId=null, campaignId=null, position=CENTER, persistent=false)
in-app message: errorWithMessage. message: InAppMessage(messageId=gist-html-01J87SG3MHFFVP758GX91CFJBR, queueId=01e0fb5e-7117-481d-a204-d786d0669348, deliveryId=null)
track an event with name in-app message action and attributes {delivery-id=NULL, event-name=errorWithMessage, message-id=gist-html-01J87SG3MHFFVP758GX91CFJBR}
JavaScript injected for postMessage
Access to XMLHttpRequest at 'https://engine-consumer-api.cloud.dev.gist.build/api/v2/configuration?cioSiteId=0f4234d28520fd1619d0&cioDatacenter=us&random=0' from origin 'http://192.168.2.86:8080' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. -- From line 0 of http://192.168.2.86:8080/web/index.html#/
Uncaught  -- From line 6090 of http://192.168.2.86:8080/web/main.dart.js
Copy link

github-actions bot commented Sep 23, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • java_layout: feature/support-larger-messages (1727097208)
  • kotlin_compose: feature/support-larger-messages (1727097201)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 7.69231% with 24 lines in your changes missing coverage. Please review.

Project coverage is 51.00%. Comparing base (8b30804) to head (ba07d07).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...inginapp/gist/presentation/engine/EngineWebView.kt 0.00% 22 Missing ⚠️
...io/customer/messaginginapp/gist/GistEnvironment.kt 0.00% 1 Missing ⚠️
...tomer/messaginginapp/gist/presentation/GistView.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #440      +/-   ##
============================================
+ Coverage     41.98%   51.00%   +9.02%     
- Complexity      259      287      +28     
============================================
  Files            99       95       -4     
  Lines          2320     2278      -42     
  Branches        344      358      +14     
============================================
+ Hits            974     1162     +188     
+ Misses         1247     1016     -231     
- Partials         99      100       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 23, 2024

📏 SDK Binary Size Comparison Report

No changes detected in SDK binary size ✅

Copy link

Build available to test
Version: feature-support-larger-messages-SNAPSHOT
Repository: https://s01.oss.sonatype.org/content/repositories/snapshots/

@stephen-pope-customer-io stephen-pope-customer-io changed the title Pass options using postMessage: DO NOT MERGE feat: Pass options using postMessage: DO NOT MERGE Sep 23, 2024
Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't want to leave the PR hanging, here the changes we would need to make to it work.

I am going to test the changes a bit more with different messages to ensure reliability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants