Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GHA workflow example and function for adding it #410

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maelle
Copy link
Member

@maelle maelle commented Jul 27, 2022

Part of #268

#' @export
#'
use_github_action_pkgcheck <- function(save_as = NULL) {
usethis::use_github_action(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since fledge already imports usethis

- cron: "30 14 * * *"

jobs:
pkgcheck:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should there be an action

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean an actual GitHub Action that someone (Wael?) would create :-)

@maelle maelle requested a review from krlmlr August 29, 2022 09:21
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we try this action on fledge first before promoting a use_*() ?

@maelle
Copy link
Member Author

maelle commented Sep 1, 2022

Good point. I'll leave this as draft for now and open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants