Forms on multi page pdfs #913
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #911 is contained in this PR and should be merged before :-) |
|
Fixes #914 |
|
FYI, for anyone visiting this page in the future, another version of this PR was merged into the new openhtmltopdf repository here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #914
Forms on PDFs with multiple pages that are not on the last page are broken. They get the last pages RenderingContext and that will calculate wrong coordinates. With this PR it will use the right page, fixing the RenderingContext to be correct and not attach a changing object to the PdfBoxForm.Control would be even better, but more intrusive.