-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add jhipster-online project #480
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maximilianoPizarro The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @maximilianoPizarro. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Would you be able to sign off on your commit so the DCO checks can pass?
Also, since this is a new stack I believe an owner needs to be assigned, are you going to assume ownership over this stack and ensure it stays up to date? I believe that's the process, correct me if I'm wrong cc @thepetk @michael-valdron
/ok-to-test |
Hi Team, Absolutely yes! Add me owner from this solution. Thanks in advance! |
/retest |
515c507
to
9fb6785
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments :)
167b718
to
be74907
Compare
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
Signed-off-by: Maximiliano Pizarro <[email protected]>
6dcb4cb
to
38f89d7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to get this imported in devspaces and everything seems to be working as intended, when trying to test with odo
I ran into an issue with the mysql
but that may have been my initial setup.
At this point in time I believe we are just waiting on time for our team to have a discussion around how to handle giving you ownership over this stack, correct me if I am wrong @thepetk @michael-valdron . After that discussion I think we can proceed with finalizing the PR review
Description of Changes
Add jhipster-online devfile.yaml and Dockerfile image from quay.io/devfile/universal-developer-image with jhipster-generator 8.1.0.
How To Test
Works in Developer Sandbox
JHipster Online on Red Hat OpenShift Dev Spaces
Install JHipster Online on OpenShift Dev Spaces
Taking a look at the Video Demo