Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed title of /query page to manage navigation menu #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bmispelon
Copy link
Member

@bmispelon bmispelon commented Oct 12, 2024

Here's how it looks like:
Screenshot 2024-10-12 at 18-49-42 View Tickets – Django

@bmispelon
Copy link
Member Author

@keikoro you mentionned the discrepancy in #209, what do you think about this change?

@bmispelon
Copy link
Member Author

@sarahboyce Since you've recently made changes on the ticket page, I was wondering if you had opinions ™️ about this. Do you think it's worth changing the title?

@sarahboyce
Copy link
Contributor

@sarahboyce Since you've recently made changes on the ticket page, I was wondering if you had opinions ™️ about this. Do you think it's worth changing the title?

Yes I think so
With all the other tabs, the tab title (or some of it) is in the page title. If the tabs became a sub-menu of "Issues" this would be clear which page you are on. So I think this is more consistent/better 👍

I don't think this will change anyone's life, but I agree with it in principle. We could also call it "Tickets"

@keikoro
Copy link

keikoro commented Oct 14, 2024

@keikoro you mentionned the discrepancy in #209, what do you think about this change?

Oh yeah, better!

We could also call it "Tickets"

I feel like "Show Tickets" would be even more accurate as people don't necessarily initially get to view tickets. What they encounter first on that page is a form, which manipulates which tickets are ultimately displayed, i.e. shown.

If people know to look for them. :P I for one didn't even immediately realise the tickets were listed below the form all along, which is why I suggested to not use the menu label as heading for the form section of the page:

The search form itself doesn't need its own heading, IMHO; it could be replaced by regular text leading into it.

If the page were set up differently, e.g. if the form were collapsed by default, just "Tickets" would make the most sense, IMO. "View tickets" could be misunderstood to mean the tickets themselves, i.e. the ticket contents, can be viewed directly from that menu.

@keikoro
Copy link

keikoro commented Oct 14, 2024

Basically, what I'm imagining is the following page structure:

Blah blah regular text leading into the filter form...

[Form]

Headline that mirrors menu label (e.g. "Show tickets")

[List of tickets]

The introductory line could be really short, its only purpose would be to acknowledge the form/filterability of the tickets, and it'd ideally make reference to the list of tickets below (which I'm guessing I didn't see because the form takes up a bit of space and I was likely looking at it from a browser window with reduced height). Ex. "Filter the list of tickets below:"

@keikoro
Copy link

keikoro commented Oct 17, 2024

To clarify: I think "Show tickets" makes the most sense with the current page structure (form visible, heading visually grouped with form); "Tickets" would work best as heading for (just) the list of tickets, i.e. if it immediately preceeded that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants