Fixed #1276 -- Added copy buttons to console and shell commands. #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabderemane
reviewed
Jun 9, 2024
There was a problem hiding this comment.
Thank you for your contribution! I believe it's better to start your contribution from @prashantpandey9's PR in order to have the initial contribution and the co-author.
| @@ -3624,6 +3624,11 @@ ul.corporate-members li { | |||
| } | |||
|
|
|||
| .code-block-caption, | |||
| .highlight-console, | |||
| .c-content-win, | |||
There was a problem hiding this comment.
I think it's missing .c-content-unix
There was a problem hiding this comment.
No need as there is a child div with .highlight-console for every section with .c-content-unix.
| if (hasClass('code-block-caption') || | ||
| hasClass('snippet') || | ||
| hasClass('highlight-console') || | ||
| hasClass('c-content-win') || |
There was a problem hiding this comment.
Same, I think it's missing .c-content-unix
|
I saw @prashantpandey9's PR, but decided to start the contribution from scratch. I think it's better not to modify existing styles but to reuse them where necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1276
Although there is a PR pending, added one as well, hope it's okay.
Added copy buttons for console and shell commands. Also added copy buttons on the Download page.
Minimum code changes, no new styles added, button adding functionality is moved to a separate function, so it can be further reused with different code blocks.
Comments aren't copied (like in an example below), nor are the promts.
