Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isTrueish #255

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

isTrueish #255

wants to merge 5 commits into from

Conversation

GammaGames
Copy link

Fixes #254

jgonggrijp
jgonggrijp requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@jgonggrijp jgonggrijp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! In #254 (comment) you asked whether util.strings was the right place. I don't have strong opinions on the matter, but it seems like this function might feel more at home in function.predicates.

underscore.util.strings.js Outdated Show resolved Hide resolved
underscore.util.strings.js Outdated Show resolved Hide resolved
test/util.strings.js Outdated Show resolved Hide resolved
@jgonggrijp
Copy link
Contributor

Ugh, the CI fails because of a linter rule: it doesn't like !!+v because the use of the ! operator is considered confusing.

Can you reproduce this locally, and if so, could you try to fix it? If changing the expression to !!(+v) silences the warning, I would prefer that, but I can also live with disabling this particular rule.

Otherwise, I will try to fiddle with it sometime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgonggrijp jgonggrijp jgonggrijp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean helper
2 participants
@GammaGames @jgonggrijp