Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0] SDL Bindings #2207

Merged
merged 30 commits into from
Oct 9, 2024
Merged

[3.0] SDL Bindings #2207

merged 30 commits into from
Oct 9, 2024

Conversation

Perksey
Copy link
Member

@Perksey Perksey commented May 31, 2024 •
edited
Loading

This is the initial set of SDL3 bindings. They will likely be modified in further PRs.

Dependencies

None.

Dependents

Perksey and others added 24 commits April 6, 2024 14:42
@Perksey
Initial group codegen
7e32758
@Perksey
Fix some trimming oddities
e53716f
@Perksey
Fix HintTargetPGI and others similarly situated
67ed5ae
@Perksey
Base typing and namespacing
678dc6e
@Perksey
Cast enum members, fix stray semicolons, Silk.NET.OpenGL builds again
52e401a
@Perksey
Group and bool transformations
5219292
@Perksey
Fix erroneous cast order
710fa56
@Perksey
Add Delete(singular) overloads (ArrayParameterOverloader)
ea85042
@Perksey
Add SAL object model & Khronos length metadata parsing
4376388
@Perksey
ArrayParameterTransformer w/ tests
3214433
@Perksey
Integrate ArrayParameterTransformer
220afd0
@Perksey
Merge branch 'develop/3.0' into feature/opengl-codegen
7eec321
@Perksey
Support SupportedApiProfileAttribute generation with metadata
4450085
@Perksey
PrettifyNames conflict resolution now actually works
d523e37
@Perksey
Fix casting transformation ambiguity bugs
90da556
@Perksey
Fix metadata retrieval for reserved identifiers
4f85362
@Perksey
Merge branch 'feature/opengl-codegen' of https://github.com/dotnet/Si…
110a782 
…lk.NET into feature/opengl-codegen
@Perksey
Fix unit tests
24343a8
@Perksey
Fixup for all caps names
ba1f9c4
@Perksey
Fix naive trimming bug
37637f5
@Perksey
More self-review comments
5eca8c3
@Perksey
SDL bindings
e2ff544
@Perksey
Merge attempt 2
9f36ade
@Perksey
Merge branch 'feature/sdl-bindings' of https://github.com/dotnet/Silk…
261ddd8 
….NET into feature/sdl-bindings
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 31, 2024 •
edited
Loading

File Coverage
All files 3% ✅

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against bc18fde

Perksey
Perksey commented Jun 6, 2024
View reviewed changes
Copy link
Member Author

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posting an old self-review, most comments are outdated and a new self-review needs to be done.

Directory.Build.targets Outdated Show resolved Hide resolved
sources/Core/Silk.NET.Core.csproj Outdated Show resolved Hide resolved
sources/SDL/SDL3/GamepadBinding.gen.cs Outdated Show resolved Hide resolved
sources/SDL/SDL3/Guid.gen.cs Outdated Show resolved Hide resolved
Perksey
Perksey commented Jun 9, 2024
View reviewed changes
Copy link
Member Author

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-review

@Perksey Perksey marked this pull request as ready for review June 9, 2024 14:27
@Perksey Perksey requested a review from a team as a code owner June 9, 2024 14:27
@Perksey
Copy link
Member Author

Perksey commented Jun 9, 2024

Self-review complete, ready for review @curin

This was referenced Oct 2, 2024
Merged
Merged
@Perksey Perksey requested a review from curin October 6, 2024 22:15
@Perksey Perksey merged commit d80ceb8 into develop/3.0 Oct 9, 2024
15 checks passed
@Perksey Perksey deleted the feature/sdl-bindings branch October 9, 2024 19:45
@Perksey Perksey mentioned this pull request Oct 16, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curin curin curin approved these changes

Assignees

@curin curin

Labels
area-Windowing
Projects
Silk.NET Development Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Perksey @curin