[Windows] Fix FlyoutPage ShouldShowToolbarButton when overridden to return false, still shows button in title bar #25857
+146
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
devanathan-vaithiyanathan
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
requested changes
Nov 14, 2024
| { | ||
|
|
||
| } | ||
| public partial class Issue24547PopoverPage : FlyoutPage |
There was a problem hiding this comment.
D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24547.cs(4,15): error CS0260: Missing partial modifier on declaration of type 'Issue24547'; another partial declaration of this type exists [D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue24547.cs(4,15): error CS0260: Missing partial modifier on declaration of type 'Issue24547'; another partial declaration of this type exists [D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
8570 Warning(s)
2 Error(s)
There was a problem hiding this comment.
I have removed the partial keyword, could you please check once and let me know.
Foda
approved these changes
Nov 14, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Nov 15, 2024
| App.WaitForElement("PopButton"); | ||
| App.Tap("PopButton"); | ||
| App.WaitForElement("DetailButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Triggered build. There are some pending snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue details
When Popover behavior is applied to a FlyoutPage with ShouldShowToolbarButton set to false, the hamburger icon still appears in the Windows title bar.
Root Cause
In Windows, When the ShouldToolBarButton is override as false, hardly setting WinUI IsPaneToggleButtonVisible as True based on FlyoutBehavior to control navigation visibility with no handling to restrict the visibility of the ToolBarButton.
Description of Change
Since we are controlling the DrawerToggleVisible value based on the visibility of the ToolBarButton, which in turn manages the visibility of the TogglePaneButton in WinUI. This ensures that the toolbar now correctly reflects the DrawerToggleVisible state, improving the consistency of navigation element.
Issues Fixed
Fixes #24547
Tested the behaviour in the following platforms
Output Screenshot