Replace backward/forward slash in ProjectAndExecutableLaunchHandlerHelpers.GetOutputDirectoryAsync with system default #9585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
approved these changes
Nov 13, 2024
| { | ||
| // Arrange | ||
| var expectedOutputDirectory = @"C:\OutputDirectory"; | ||
| var expectedOutputDirectory = RuntimeInformation.IsOSPlatform(OSPlatform.Windows) ? expectedOutputDirectoryOnWindows : expectedOutputDirectoryOnLinux; |
There was a problem hiding this comment.
Do we run these tests on Linux/OSX in any CI? Maybe for DevKit?
There was a problem hiding this comment.
Hey @drewnoakes
I've verified the test on my local machine on linux via WSL though. However, I don't think the current CI in dotnet-project-system runs on linux/macOS though, which IMO should be enabled somewhere since Microsoft.VisualStudio.ProjectSystem.Managed is consumed by C# DevKit. What I am not so sure about is where and how to enable these tests on linux machine, maybe we can discuss offline.
BTW Here's the current test result for Microsoft.VisualStudio.ProjectSystem.Managed.UnitTests on linux, where most of the failure test cases are from path sepereter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9584
Microsoft Reviewers: Open in CodeFlow