Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance explicit interface implementation completion provider #75568

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Enhance explicit interface implementation completion provider #75568

wants to merge 35 commits into from

Commits on Oct 19, 2024

  1. Offer completion without return type

    @Rekkonnect
    Rekkonnect committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    219a780 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Implement as a member inserting provider

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    dfb7cfb View commit details
    Browse the repository at this point in the history

  2. Adjust commit behavior tests

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    c6bdfec View commit details
    Browse the repository at this point in the history

  3. Share implementation with overload completion

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    8b3936c View commit details
    Browse the repository at this point in the history

  4. Fix member name splitting

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    7b1a029 View commit details
    Browse the repository at this point in the history

  5. Fix completion provider

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    c80b651 View commit details
    Browse the repository at this point in the history

  6. Fix trivia and formatting

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    b7705b7 View commit details
    Browse the repository at this point in the history

  7. Only remove tokens when node extends beyond the line

    @Rekkonnect
    Rekkonnect committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    5afac24 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Fix generation location

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1740ae0 View commit details
    Browse the repository at this point in the history

  2. Fix removed line span

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    167adf2 View commit details
    Browse the repository at this point in the history

  3. Handle conversion operators

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    0f0027c View commit details
    Browse the repository at this point in the history

  4. Fix item commit tests

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    18aae6b View commit details
    Browse the repository at this point in the history

  5. Fix properties and events

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    bb2eaa2 View commit details
    Browse the repository at this point in the history

  6. Add more tests

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    597408a View commit details
    Browse the repository at this point in the history

  7. Fix nullability warning

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    1d6eb9d View commit details
    Browse the repository at this point in the history

  8. Add skipped failing test for dotnet#70458

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    5c3132c View commit details
    Browse the repository at this point in the history

  9. Fix failing test

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    2dc4ecf View commit details
    Browse the repository at this point in the history

  10. Remove spell fix suggestions on explicit interface implementations

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6717df7 View commit details
    Browse the repository at this point in the history

  11. Only remove CS0539 on spell fix provider

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    40cd75c View commit details
    Browse the repository at this point in the history

  12. Revive spell fix tests and assert missing spell fixes

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    3cd8104 View commit details
    Browse the repository at this point in the history

  13. Add tests for nested interfaces

    @Rekkonnect
    Rekkonnect committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    d68cd2b View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Fix test regression

    @Rekkonnect
    Rekkonnect committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f3f028d View commit details
    Browse the repository at this point in the history

  2. Fix explicit implementation parameter attributes

    @Rekkonnect
    Rekkonnect committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3ab46c5 View commit details
    Browse the repository at this point in the history

  3. Remove leftover parameter

    @Rekkonnect
    Rekkonnect committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e94f2cf View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Fix broken tests

    @Rekkonnect
    Rekkonnect committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    062b705 View commit details
    Browse the repository at this point in the history

  2. Add extra trailing trivia test

    @Rekkonnect
    Rekkonnect committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    07a8599 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @Rekkonnect
    Rekkonnect committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    88b726e View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Remove default parameter value from explicit impl

    @Rekkonnect
    Rekkonnect committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    cc673cb View commit details
    Browse the repository at this point in the history

  2. Fix failing test

    @Rekkonnect
    Rekkonnect committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    0bce3fd View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Review comments

    @Rekkonnect
    Rekkonnect committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1ae949f View commit details
    Browse the repository at this point in the history

  2. Handle scoped

    @Rekkonnect
    Rekkonnect committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    7b0f668 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into feature/75435-explicit-interface-impl-sugges… 

    …tions
    @Rekkonnect
    Rekkonnect committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    de4e2c8 View commit details
    Browse the repository at this point in the history

  4. Fix formatting

    @Rekkonnect
    Rekkonnect committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5bab752 View commit details
    Browse the repository at this point in the history

  5. Prefer using service interface

    @Rekkonnect
    Rekkonnect committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    381b125 View commit details
    Browse the repository at this point in the history

  6. Add docs + improve code

    @Rekkonnect
    Rekkonnect committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    58e7e86 View commit details
    Browse the repository at this point in the history