[WASI] Skip signal handler registration on WASI #109838
Open
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
dicej
changed the title
dicej
force-pushed
the
skip-wasi-signal-handler-registration
branch
from
1e44681
to
b45da08
Compare
3 tasks
danmoseley
reviewed
Nov 15, 2024
src/libraries/Microsoft.Extensions.Hosting/src/Internal/ConsoleLifetime.netcoreapp.cs
Outdated
Show resolved
Hide resolved
WASI does not support POSIX signals, but `Microsoft.Extensions.Hosting` works fine as long as we don't try to register or deregister signal handlers. Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
skip-wasi-signal-handler-registration
branch
from
b45da08
to
66d414f
Compare
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASI does not support POSIX signals, but
Microsoft.Extensions.Hostingworks fine as long as we don't try to register or deregister signal handlers.