Update the sdk target to net10.0 #43015

v-wuzhai · 2024-08-27T05:43:53Z

No description provided.

…pdate-the-sdk-target-to-net10.0

Directory.Build.props

src/SourceBuild/content/Directory.Build.props

…pdate-the-sdk-target-to-net10.0

v-wuzhai · 2024-10-08T08:14:33Z

There are a bunch of template test failure error messages as follows:

warning MSB4011: "/Users/runner/work/1/s/artifacts/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24504.4/tools/Tests.targets" cannot be imported again. It was already imported at "/Users/runner/work/1/s/artifacts/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24504.4/tools/Imports.targets (12,3)". This is most likely a build authoring error. This subsequent import will be ignored. [/Users/runner/work/1/s/artifacts/tmp/Release/dotnet-new.IntegrationTests/Restore_Basic/20241008062742474/Target/Output/MyProject.csproj]\n/Users/runner/work/1/s/artifacts/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24504.4/tools/GenerateChecksums.targets(4,71):
error MSB4022: The result "" of evaluating the value "$(ArcadeSdkBuildTasksAssembly)" of the "AssemblyFile" attribute in element is not valid. [/Users/runner/work/1/s/artifacts/tmp/Release/dotnet-new.IntegrationTests/Restore_Basic/20241008062742474/Target/Output/MyProject.csproj]\nStdErr:\nRestore failed.\nPost action failed.\nManual instructions: Run 'dotnet restore'\n

@dotnet/templating-engine-maintainers @dotnet/arcade-contrib Could you please take a look at this issue?

v-wuzhai · 2024-10-09T07:05:45Z

Directory.Build.props

    <ToolsetTargetFramework>$(SdkTargetFramework)</ToolsetTargetFramework>
    <VisualStudioServiceTargetFramework>net8.0</VisualStudioServiceTargetFramework>

    <!-- We used to have scenarios where the MSBuild host (VSMac) had an older .NET, but don't any more. -->
-    <ResolverTargetFramework>$(SdkTargetFramework)</ResolverTargetFramework>
+    <ResolverTargetFramework>net9.0</ResolverTargetFramework>


Here is the build error message when set to net10.0.

C:\Users\AzureTest\Desktop\109\sdk\.dotnet\sdk\10.0.100-alpha.1.24507.21\Microsoft.Common.CurrentVersion.targets(1889,5): error NU1702: ProjectReference 'C:\Users\AzureTest\Desktop\109\sdk\test\Microsoft.NET.TestFramework\Microsoft.NET.TestFramework.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETCoreApp,Version=v9.0'. This project may not be fully compatible with your project. C:\Users\AzureTest\Desktop\109\sdk\.dotnet\sdk\10.0.100-alpha.1.24507.21\Microsoft.Common.CurrentVersion.targets(1889,5): error NU1702: ProjectReference 'C:\Users\AzureTest\Desktop\109\sdk\src\Cli\Microsoft.DotNet.Cli.Utils\Microsoft.DotNet.Cli.Utils.csproj' was resolved using '.NETFramework,Version=v4.7.2' instead of the project target framework '.NETCoreApp,Version=v9.0'. This project may not be fully compatible with your project.

kasperk81 · 2024-10-09T20:51:48Z

warning MSB4011: "/Users/runner/work/1/s/artifacts/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24504.4/tools/Tests.targets" cannot be imported again. It was already imported at "/Users/runner/work/1/s/artifacts/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24504.4/tools/Imports.targets (12,3)". This is most likely a build authoring error. This subsequent import will be ignored. [/Users/runner/work/1/s/artifacts/tmp/Release/dotnet-new.IntegrationTests/Restore_Basic/20241008062742474/Target/Output/MyProject.csproj]\n/Users/runner/work/1/s/artifacts/.nuget/packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.24504.4/tools/GenerateChecksums.targets(4,71):
error MSB4022: The result "" of evaluating the value "$(ArcadeSdkBuildTasksAssembly)" of the "AssemblyFile" attribute in element is not valid. [/Users/runner/work/1/s/artifacts/tmp/Release/dotnet-new.IntegrationTests/Restore_Basic/20241008062742474/Target/Output/MyProject.csproj]\nStdErr:\nRestore failed.\nPost action failed.\nManual instructions: Run 'dotnet restore'\n

@mmitche do you recall these errors from dotnet/arcade#12740

net10 templates are blocked

mmitche · 2024-10-10T15:44:44Z

@kasperk81 I think the Arcade issue is a red herring. When the tests are being run, the .NET SDK imports the Directory.Build.targets from the root of the SDK repo, which then imports the arcade targets. I am pretty sure this is not intended for template tests as they aren't really testing the simple create+restore flow. In a helix run, I don't think this ends up happening because the SDK's repo content isn't on the machine, so that's good.

There is a Directory.Build.props file that is set up as part of the test run in the test temp dir. I think there needs to be a corresponding Directory.Build.targets alongside it to avoid accidentally importing Directory.Build..targets from the SDK repo.

/cc @nagilson and @marcpopMSFT

kasperk81 · 2024-10-10T16:58:21Z

/Users/runner/work/1/s/test/UnitTests.proj(109,5): error MSB3030: Could not copy the file "/Users/runner/work/1/s/artifacts/tmp/Release/NuGet.config" because it was not found.
##[error]test/UnitTests.proj(109,5): error MSB3030: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy the file "/Users/runner/work/1/s/artifacts/tmp/Release/NuGet.config" because it was not found.

these are persistent. when is nuget.config gets copied in artifacts?

vmr is dotnet/arcade#15153 (comment) (need arcade bump, applies to all prs not just this one)

mmitche · 2024-10-10T20:37:44Z

@kasperk81 It's due to this change:

https://github.com/dotnet/sdk/pull/43015/files#diff-37aabd56f54205e41e1a83387bfefad4ff62b60b0ec360e3beb1160d1c635722R20

That causes the targets in src/Tests/Microsoft.NET.TestFramework/SetupTestRoot.targets to not run. I think the conditionals in that file look pretty suspect. I'm guessing they were working around some race condition.

mmitche · 2024-10-10T22:08:27Z

dotnet-format uses NetCurrent right now. I think it should be using SdkTargetFramework

Co-authored-by: Adeel Mujahid <[email protected]>

lewing · 2024-11-04T21:14:02Z

@javiercn one of the blazor tests needs an update it looks like. Is that you who should take a look? Expected manifest Identity of ${ProjectPath}\Client\obj\Debug${Tfm}\blazor.publish.boot.json but found ${ProjectPath}\Client\obj\Debug${Tfm}\publish.blazor.boot.json. Expected manifest OriginalItemSpec of ${ProjectPath}\Client\obj\Debug${Tfm}\blazor.publish.boot.json but found ${ProjectPath}\Client\obj\Debug${Tfm}\publish.blazor.boot.json.

This is expected, we should just change the test here. cc @maraf

am11 · 2024-11-04T23:09:39Z

Looks like it needs merge-from-main.

ViktorHofer · 2024-11-05T08:20:53Z

The added patch should fix the wpf SDK mismatch issue but I wouldn't be surprised if that repo needs an additional change due to BCL changes. Let's see.

maraf · 2024-11-05T10:03:30Z

@javiercn one of the blazor tests needs an update it looks like. Is that you who should take a look?

Resolved by merging main

ViktorHofer · 2024-11-05T10:11:14Z

D:\a_work\1\vmr.dotnet\sdk\10.0.100-alpha.1.24551.9\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(266,5): error NETSDK1060: Error reading assets file: Error loading lock file 'D:\a_work\1\vmr\src\wpf\artifacts\obj\Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral\project.assets.json' : Could not load file or assembly 'System.Text.Json, Version=8.0.0.4, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified. [D:\a_work\1\vmr\src\wpf\packaging\Microsoft.NET.Sdk.WindowsDesktop\Microsoft.NET.Sdk.WindowsDesktop.ArchNeutral.csproj]

Hmm that one is annoying. The wpf repo builds with desktop msbuild. The VS version that is part of the build image is Preview 17.11.0-pre.2.1:

That VS installation seems to be missing dotnet/msbuild@7500f06 which updated the STJ binding redirects to 8.0.0.4. Apparently NuGet assemblies depend on the 8.0.0.4 version though. @rainersigwald ideas?

Btw I'm not sure why the windows.vs2022.preview image is lagging behind so much. It would be great if it could get updated to a VS17.12 version. Filed dotnet/dnceng#4403

jjonescz · 2024-11-05T10:17:03Z

FWIW, there's a workaround shown at https://github.com/dotnet/core/blob/main/release-notes/9.0/known-issues.md#net-sdk-90100-rc1-will-fail-when-used-with-visual-studio-1711

ViktorHofer · 2024-11-05T10:20:17Z

Yes, the workaround is checked into the Arcade.Sdk and runs by default. The binlog shows that the target runs but the ResolvePackageAssets task is still failing:

ViktorHofer · 2024-11-05T12:14:44Z

OK lol, the workaround is broken with 10.0.100 SDK versions because dotnet-watch doesn't have a STJ assembly anymore:

Submitted dotnet/arcade#15218 to update the workaround

ViktorHofer · 2024-11-05T14:29:56Z

Now windowsdesktop (sigh). Still, all those failures are really helpful as they show us where our infrastructure could be improved.

ViktorHofer · 2024-11-05T17:00:07Z

A bit thanks to our community contributors @am11 and @kasperk81 for helping getting this in. You are amazing! 🎉

…ion (#10030) * Keep apphostpack version in sync with targeting and runtime pack version Unblocks dotnet/sdk#43015 WPF uses a "live" version of the .NETCoreApp targeting and runtime pack. Also use the live version for the apphost pack so that vcxprojs don't depend on the version inside the SDK. * Update RuntimeFrameworkReference.targets * Create Tools.props * Update RuntimeFrameworkReference.targets * Update RuntimeFrameworkReference.targets * Update RuntimeFrameworkReference.targets * Update Tools.props * PR feedback and adding comments * Add more comments and consider version properties in conditions

am11 · 2024-11-05T18:12:18Z

Haha, classic move! Sometimes all it takes is a well-timed game-changing commit like I hate patches.patch to solve the mystery! 😜 Huge props to @ViktorHofer and others for the detective work! 🕵️‍♂️🏆

Fixes #9490 Unblocks dotnet/sdk#43015 When building wpf inside the VMR, a 10.0.100 SDK is used. WPF currently still targets net9.0. As WPF directly depends on runtime, it already uses 10.0.0-alpha versions of the targeting and runtime packs for managed projects. Enable this for vcxprojs as well so that the host packages can also be restored from the flowing runtime dependency. Fixes errors like these: > The Apphost pack is not installed and NuGet package restore is not supported. Upgrade Visual Studio, remove global.json if it specifies a certain SDK version, and uninstall the newer SDK. For more options visit https://aka.ms/targeting-apphost-pack-missing Pack Type:Apphost, Pack directory: D:\a\_work\1\vmr\.dotnet\packs\Microsoft.NETCore.App.Host.win-x64, targetframework: net9.0, Pack PackageId: Microsoft.NETCore.App.Host.win-x64, Pack Package Version: 9.0.0-rc.2.24473.5

v-wuzhai added 2 commits August 26, 2024 22:42

Update the sdk target to net10.0

8480f31

Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/U…

10d8ad6

…pdate-the-sdk-target-to-net10.0

v-wuzhai requested review from marcpopMSFT and a team August 27, 2024 05:43

v-wuzhai requested review from a team and vijayrkn as code owners August 27, 2024 05:43

dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Aug 27, 2024

build-analysis bot mentioned this pull request Aug 27, 2024

error MSB3030: (NETCORE_ENGINEERING_TELEMETRY=Build) Could not copy the file #42964

Closed

ViktorHofer reviewed Aug 27, 2024

View reviewed changes

Directory.Build.props Show resolved Hide resolved

mthalman reviewed Aug 27, 2024

View reviewed changes

src/SourceBuild/content/Directory.Build.props Show resolved Hide resolved

marcpopMSFT mentioned this pull request Sep 12, 2024

Main branch net10.0 transition status tracking #42920

Open

Merge branch 'main' of https://github.com/dotnet/sdk into dev/Jason/U…

6003d81

…pdate-the-sdk-target-to-net10.0

v-wuzhai requested a review from a team as a code owner October 8, 2024 03:04

Unlock the build

ba19dd8

v-wuzhai commented Oct 9, 2024

View reviewed changes

Add an empty Directory.Build.targets

d69e52c

Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0

eb0cd8a

Switch the resolvers and test project to net10.0

c4d1281

Move dotnet-format to use SdkTargetFramework

7d18b09

switch to the windows only msbuild fact

8f28cbc

Co-authored-by: Adeel Mujahid <[email protected]>

build-analysis bot mentioned this pull request Nov 4, 2024

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

nagilson and others added 3 commits November 4, 2024 16:05

Merge branch 'main' into dev/Jason/Update-the-sdk-target-to-net10.0

6d2c4eb

Add Reason property to and update baselines

7a3c6e7

Add wpf patch

482ad03

ViktorHofer mentioned this pull request Nov 5, 2024

The windows.vs2022* images are lagging behind significantly dotnet/dnceng#4403

Open

ViktorHofer added 2 commits November 5, 2024 13:15

Add Arcade patch

c0cdf43

Damn, I hate patches

575036c

Add windowsdesktop patch

3820c21

ViktorHofer approved these changes Nov 5, 2024

View reviewed changes

ViktorHofer enabled auto-merge (squash) November 5, 2024 17:02

ViktorHofer merged commit ffd7663 into main Nov 5, 2024
37 checks passed

ViktorHofer deleted the dev/Jason/Update-the-sdk-target-to-net10.0 branch November 5, 2024 17:08

mthalman mentioned this pull request Nov 5, 2024

sln-list: Support for slnx #44537

Merged

This was referenced Nov 6, 2024

[main] Publishing of SDK diff baseline PR failing after net10.0 upgrade dotnet/source-build#4720

Closed

Target net10.0 in RepoTasks dotnet/aspnetcore#58823

Open

am11 mentioned this pull request Nov 13, 2024

Add VMR leg that builds test projects #44843

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the sdk target to net10.0 #43015

Update the sdk target to net10.0 #43015

v-wuzhai commented Aug 27, 2024

v-wuzhai commented Oct 8, 2024

v-wuzhai Oct 9, 2024

kasperk81 commented Oct 9, 2024

mmitche commented Oct 10, 2024 •

edited

Loading

kasperk81 commented Oct 10, 2024 •

edited

Loading

mmitche commented Oct 10, 2024

mmitche commented Oct 10, 2024

lewing commented Nov 4, 2024

am11 commented Nov 4, 2024

ViktorHofer commented Nov 5, 2024

maraf commented Nov 5, 2024

ViktorHofer commented Nov 5, 2024 •

edited

Loading

jjonescz commented Nov 5, 2024

ViktorHofer commented Nov 5, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024

am11 commented Nov 5, 2024

Update the sdk target to net10.0 #43015

Update the sdk target to net10.0 #43015

Conversation

v-wuzhai commented Aug 27, 2024

v-wuzhai commented Oct 8, 2024

v-wuzhai Oct 9, 2024

Choose a reason for hiding this comment

kasperk81 commented Oct 9, 2024

mmitche commented Oct 10, 2024 • edited Loading

kasperk81 commented Oct 10, 2024 • edited Loading

mmitche commented Oct 10, 2024

mmitche commented Oct 10, 2024

lewing commented Nov 4, 2024

am11 commented Nov 4, 2024

ViktorHofer commented Nov 5, 2024

maraf commented Nov 5, 2024

ViktorHofer commented Nov 5, 2024 • edited Loading

jjonescz commented Nov 5, 2024

ViktorHofer commented Nov 5, 2024 • edited Loading

ViktorHofer commented Nov 5, 2024 • edited Loading

ViktorHofer commented Nov 5, 2024 • edited Loading

ViktorHofer commented Nov 5, 2024

am11 commented Nov 5, 2024

mmitche commented Oct 10, 2024 •

edited

Loading

kasperk81 commented Oct 10, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024 •

edited

Loading

ViktorHofer commented Nov 5, 2024 •

edited

Loading