Optimize lookups in FontEmbeddingManager, use HashSet over Dictionary #10002
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimizes methods in
FontEmbeddingManager
, usingHashSet<ushort>
overDictionary<ushort, bool>
since thebool
is useless and as the comment says, it was always the plan anyways.GetUsedGlyphs
throwsKeyNotFoundException
overArgumentException
but that bug was already present.3 Different faces, 9 Glyph Runs
Benchmark data source
1 font, 9 Glyph Runs (XpsFontSubsetter scenario)
Benchmark data source
Customer Impact
Improved performance, slightly decreased allocations. This is used by the
XpsFontSubsetter
, so it could gain a bit of perf.Regression
No.
Testing
Local build.
Risk
Low, just a simple swap.
Microsoft Reviewers: Open in CodeFlow