refactor(us-mida-pjm): upgrade US-MIDA-PJM parser with event classes #6635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactor to use event classes
github-actions
bot
added
parser
python
amv213
commented
Apr 5, 2024
VIKTORVAV99
reviewed
Apr 7, 2024
Comment on lines
301
to
+306
| if target_datetime is not None: | ||
| raise NotImplementedError("This parser is not yet able to parse past dates") | ||
| raise ParserException( | ||
| PARSER, | ||
| "This parser is not yet able to parse historical data", | ||
| sorted_zone_keys, | ||
| ) |
There was a problem hiding this comment.
This might be a blocker for the above though...
We generally prefer parsers that can fetch historical data (even if it's delayed) over realtime only parsers.
However in the future we might support using multiple parsers for the same data types then this would be really valuable.
Regardless I'll check with the team.
|
Perfect - thank you so much @VIKTORVAV99! no rush on my side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#6011
Description
This PR upgrades the US-MIDA-PJM parser to use event classes.
I have also fixed the
.fetch_exchange()function, and expanded it to support all possible neighbouring exchanges. I also fixed a small bug that I found.Double check
poetry run test_parser "zone_key"pnpx prettier@2 --write .andpoetry run formatin the top level directory to format my changes.