Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't merge asars that are identical in the x64 and arm64 versions #68

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aprilandjan
Copy link

Currently, the mergeASARs workflow will always be done even if the two asar files are identical, which seems to be unnecessary and not fit for the annotation right before the code block:

I f we have an ASAR we just need to check if the two "app.asar" files have the same hash,
if they are, same as above, we can leave one there and call it a day. If they're different
we have to make a dynamic entrypoint.

This PR simply move mergeASARs workflow into the branch of different asar files. Otherwise, use one of them directly.

Please have a look :)

…ons even if options.mergeASARs is set to true
@aprilandjan aprilandjan requested a review from a team as a code owner April 13, 2023 11:01
@erickzhao erickzhao changed the title feat: don't merge asars that are identical in the x64 and arm64 versions refactor: don't merge asars that are identical in the x64 and arm64 versions Jun 12, 2024
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants