feat: add new setting to select line height options #3034
+96
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for elk-docs failed.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shuuji3
force-pushed
the
shuuji3/feat/line-height
branch
from
26b8f6b
to
b24b53c
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@iconify/[email protected], npm/@iconify/[email protected] |
shuuji3
commented
Nov 1, 2024
| @@ -125,8 +125,16 @@ em-emoji-picker { | |||
| } | |||
| } | |||
|
|
|||
| .line-compact { | |||
| line-height: calc(4 / 3 * 1em); | |||
There was a problem hiding this comment.
Removed the unit em following the recommendation by MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#values):
In most cases, this is the preferred way to set line-height and avoid unexpected results due to inheritance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3007
This PR implements a new setting to select line height in the post body. Users can choose the narrower (1.2) or wider (1.5) line height options, in addition to the current normal option (4/3)
Screenshots
Setting section for line height
Narrow (1.2)
Normal (4/3 = 1.33...): current and default value
Wide (1.5)