-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix displaying etcd logo in README on a dark theme #18891
Conversation
Hi @alexandear. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
9daf4c6
to
600eeb7
Compare
/ok-to-test |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 28 files with indirect coverage changes @@ Coverage Diff @@
## main #18891 +/- ##
==========================================
- Coverage 68.81% 68.63% -0.18%
==========================================
Files 420 420
Lines 35532 35558 +26
==========================================
- Hits 24450 24406 -44
- Misses 9658 9720 +62
- Partials 1424 1432 +8 Continue to review full report in Codecov by Sentry.
|
Perhaps we should standardize the white background logo with the black version from the CNCF repo? https://github.com/cncf/artwork/tree/main/projects/etcd/horizontal But we can also keep the color one. I don't have a strong opinion. |
600eeb7
to
8928654
Compare
1bbe937
to
d88ee9f
Compare
Signed-off-by: Oleksandr Redko <[email protected]>
d88ee9f
to
dd578f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @alexandear
/test pull-etcd-integration-1-cpu-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @alexandear.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexandear, ivanvc, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR fixes displaying the etcd logo in README.md on a GitHub dark theme.
Before/after screenshots
Before (dark):
After (dark):
Before (light):
After (light):
See this doc for implementation details.