Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying etcd logo in README on a dark theme #18891

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Nov 14, 2024

This PR fixes displaying the etcd logo in README.md on a GitHub dark theme.

Before/after screenshots

Before (dark):

image

After (dark):

image

Before (light):

image

After (light):

image

See this doc for implementation details.

@k8s-ci-robot
Copy link

Hi @alexandear. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alexandear alexandear changed the title Use white logo for dark GitHub theme Fix displaying etcd logo in README on a dark theme Nov 14, 2024
@ivanvc
Copy link
Member

ivanvc commented Nov 14, 2024

/ok-to-test

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 68.63%. Comparing base (19aa0db) to head (5ecb6d6).
Report is 10 commits behind head on main.

Current head 5ecb6d6 differs from pull request most recent head dd578f4

Please upload reports for the commit dd578f4 to get more accurate results.

Files with missing lines Patch % Lines
server/etcdmain/grpc_proxy.go 6.45% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdmain/grpc_proxy.go 14.52% <6.45%> (-0.53%) ⬇️

... and 28 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18891      +/-   ##
==========================================
- Coverage   68.81%   68.63%   -0.18%     
==========================================
  Files         420      420              
  Lines       35532    35558      +26     
==========================================
- Hits        24450    24406      -44     
- Misses       9658     9720      +62     
- Partials     1424     1432       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19aa0db...dd578f4. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Nov 14, 2024

Perhaps we should standardize the white background logo with the black version from the CNCF repo? https://github.com/cncf/artwork/tree/main/projects/etcd/horizontal

But we can also keep the color one. I don't have a strong opinion.

README.md Show resolved Hide resolved
@alexandear alexandear force-pushed the readme-logo-dark-theme branch 4 times, most recently from 1bbe937 to d88ee9f Compare November 15, 2024 12:05
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @alexandear

@jmhbnz
Copy link
Member

jmhbnz commented Nov 15, 2024

/test pull-etcd-integration-1-cpu-amd64

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @alexandear.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandear, ivanvc, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 6de50f9 into etcd-io:main Nov 15, 2024
33 checks passed
@alexandear alexandear deleted the readme-logo-dark-theme branch November 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants