Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled start_time_stamp and end_time_stamp parameters #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmlogic
Copy link

@dmlogic dmlogic commented Oct 15, 2012

Hi

I had a usage where I needed to pass pre-formatted dates. Have adjusted the entry() function so it will pick from start_time or start_time_stamp as appropriate (same for end_time).

@amacneil
Copy link
Member

What's the use case for this? Have you got custom channel fields with pre-formatted dates? Half the point of this plugin was to handle the difficult ical date format. Would also need some documentation before I can merge.

@dmlogic
Copy link
Author

dmlogic commented Oct 16, 2012

Pretty much yes.

In this case we're using Low Events for a calendar that must always show the precise time and date entered. Now I could pass the dates format="%U" and trust EE to play nice but we've been bitten by DST quirks way too many times. This way I know the date we enter is the date that gets displayed now and for ever.

I can also see other instances where dates are coming from places where timestamps are not stored. For example this project includes data pulled from a Microsoft CRM which already has it's dates in the iCal output format. We may well need to push some of that data out later on.

It's working for us anyway so I thought I'd share. I'm easy as to whether you think it's worth having for everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants