-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a setting to enable auto-refreshing the inspector tree #8483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/inspector_v2/inspector_screen_body.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/inspector_v2/inspector_controller.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Oct 28, 2024
mossmana
pushed a commit
to mossmana/devtools
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the setting is off by default, once I've verified that it's performant I will switch it to on by default.
Note: Filed #8482 for tests, since we don't currently have the infrastructure in place to perform code edits.
Demos:
Auto-refresh after modifying
Padding
:Auto-refresh after removing
Padding
:Note: As you can see below, we don't always "guess" the correct widget to select after a refresh. I filed #8481 for a potential different algorithm we could try: