Make username optional for flux create secret git
#4119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talife
force-pushed
the
git-source-token
branch
from
8136bec
to
ff49907
Compare
makkes
force-pushed
the
git-source-token
branch
2 times, most recently
from
0e19256
to
6db6197
Compare
Git authentication with basic auth doesn't necessarily require a username to be present. Signed-off-by: talife <[email protected]> Signed-off-by: Max Jonas Werner <[email protected]>
makkes
force-pushed
the
git-source-token
branch
from
6db6197
to
a6cb593
Compare
stefanprodan
changed the title
flux create secret git
|
This should not work, as we validate a HTTP/S URL to contain a username in the underlying Git library: https://github.com/fluxcd/pkg/blob/12b79e9629e18524dc0d10b71f9df252784c5fa9/git/options.go#L62-L65 Given you highlight in the issue that manually constructing the Secret works as expected, I am wondering if you are trying to create the Secret for an SSH URL without having |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3892
test added with a golden file to create a secret with only a password key.