Stop iterating over all resources for finding matching identifiers #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1410 and will improve on the symptoms mentioned by @theAkito in #1375.
This commit changes the behaviour of
FoamWorkspace.getIdentifier. Instead of iterating over all resources it will reap the benefits of the TrieMap. I've changed the algorithm to take the basename as identifier. This is then used to list all matching resources for that identifier. Internally, this uses the reversed TrieMap identifier. Optimising the retrieval of any matching resources of the given identifier.This removes the cartesian product causing the problems in #1410.
@riccardoferretti Please check and verify.