-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ticket buying option into creation wizard #424
base: development
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR adds a new ticket buying option in the event creation wizard that allows event organizers to require registered accounts for ticket purchases. The implementation includes UI changes to the quick setup form, form field definition, and the corresponding backend logic to save this setting. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider setting require_registered_account_for_tickets to False by default, as forcing account creation could be too restrictive for many events. Let organizers opt-in to this restriction rather than having to opt-out.
- The settings handling is inconsistent - require_registered_account_for_tickets is saved directly while other settings use the general settings mechanism. Consider using the standard settings approach for consistency.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This PR resolves #374
Add ticket buying option into creation wizard
Summary by Sourcery
New Features: