Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ticket buying option into creation wizard #424

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Nov 8, 2024

This PR resolves #374

Add ticket buying option into creation wizard

image

Summary by Sourcery

New Features:

  • Introduce a new option in the event creation wizard to require registered accounts for ticket purchases.

Copy link

sourcery-ai bot commented Nov 8, 2024

Reviewer's Guide by Sourcery

This PR adds a new ticket buying option in the event creation wizard that allows event organizers to require registered accounts for ticket purchases. The implementation includes UI changes to the quick setup form, form field definition, and the corresponding backend logic to save this setting.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added new ticket buying settings section in the quick setup wizard
  • Added a new fieldset with a ticket buying settings section
  • Included a form field for requiring registered accounts
  • Added appropriate icon and styling consistent with existing sections
src/pretix/control/templates/pretixcontrol/event/quick_setup.html
Implemented form field definition for registered account requirement
  • Added new BooleanField for require_registered_account_for_tickets
  • Added descriptive label and help text explaining the feature
src/pretix/control/forms/event.py
Added backend logic to handle the new setting
  • Set default value to True in get_initial
  • Added logic to save the setting in form_valid method
  • Integrated with event settings system
src/pretix/control/views/event.py

Assessment against linked issues

Issue Objective Addressed Explanation
#374 Add ticket buying option to require registered accounts in the event creation wizard
#374 Place the option below 'Create ticket type' and above 'Features'
#374 Activate the option by default

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@lcduong lcduong marked this pull request as ready for review November 8, 2024 08:13
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider setting require_registered_account_for_tickets to False by default, as forcing account creation could be too restrictive for many events. Let organizers opt-in to this restriction rather than having to opt-out.
  • The settings handling is inconsistent - require_registered_account_for_tickets is saved directly while other settings use the general settings mechanism. Consider using the standard settings approach for consistency.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ticket buying option into creation wizard
1 participant