Add getting-started to part 2 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avivace
requested changes
Jul 11, 2022
Rangi42
reviewed
Jul 11, 2022
Rangi42
reviewed
Jul 11, 2022
Rangi42
reviewed
Jul 11, 2022
Rangi42
reviewed
Jul 11, 2022
Co-authored-by: Eldred Habert <[email protected]>
avivace
requested changes
Jul 15, 2022
src/part2/getting-started.md
Outdated
| ``` | ||
|
|
||
| This loop might look familiar if you've read part 1. | ||
| It copies `Tiles` to `$9000`, which is the part of VRAM where tiles are stored. |
There was a problem hiding this comment.
My suggestion meant to try to clarify what $9000 was (a choice in a range?)
src/part2/getting-started.md
Outdated
|
|
||
| (A note about OPT g could be added here?) | ||
|
|
||
| We already have tiles made for this project, so you can copy [this premade file](https://github.com/ISSOtm/gb-asm-tutorial-part2/raw/main/tileset.asm), and paste it at the end of your code. |
There was a problem hiding this comment.
I don't think #17 should be blocking, as it involves a large amount of work to set everything up. Please just start with the example code "imported"..
avivace
reviewed
Aug 5, 2022
Co-authored-by: Antonio Vivace <[email protected]>
|
I've just added the code to this lesson, using the same method as part 1. It should be ready to release now. |
Place it outside of `src` so that it doesn't get served
ISSOtm
requested changes
Aug 12, 2022
Co-authored-by: Eldred Habert <[email protected]>
Closed
avivace
approved these changes
Aug 13, 2022
ISSOtm
approved these changes
Aug 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.