Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify palettes bootrom behavior #576

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

alloncm
Copy link
Contributor

@alloncm alloncm commented Oct 30, 2024

I found the lack of a reference to the boot up sequence and the statement about the bootrom setting the object palettes confusing.
I hope this helps :)

Also update DEPLOY.md recommended python version

Also update DEPLOY.md recomended python version
@avivace avivace requested a review from ISSOtm November 2, 2024 22:58
src/Palettes.md Outdated Show resolved Hide resolved
@alloncm alloncm requested a review from avivace November 4, 2024 19:01
src/Palettes.md Outdated Show resolved Hide resolved
@alloncm alloncm requested a review from ISSOtm November 6, 2024 19:14
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The content looks good, I have just one last nitpick, and then we should be good to merge :)

src/Palettes.md Outdated Show resolved Hide resolved
Co-authored-by: Eldred Habert <[email protected]>
@alloncm alloncm requested a review from ISSOtm November 9, 2024 21:13
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ISSOtm ISSOtm merged commit 18adfb8 into gbdev:master Nov 9, 2024
3 checks passed
@alloncm alloncm deleted the clarify-cgb-bootrom-actions branch November 9, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants