feat(hydration error): Create a tree-view that highlights dom mutations directly #80808
+287
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ryan953
commented
Nov 15, 2024
ryan953
commented
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80808 +/- ##
==========================================
+ Coverage 74.97% 78.39% +3.41%
==========================================
Files 7207 7208 +1
Lines 319509 319549 +40
Branches 44001 44003 +2
==========================================
+ Hits 239546 250498 +10952
+ Misses 73442 62671 -10771
+ Partials 6521 6380 -141 |
billyvg
reviewed
Nov 15, 2024
| }); | ||
|
|
||
| const timeIndexedMutations = Array.from(data?.values() ?? []).reduce( | ||
| (mutation, acc) => { |
There was a problem hiding this comment.
Is this not switched? accumulator should be first arg
ryan953
commented
Nov 16, 2024
| queryFn: () => | ||
| extractDiffMutations({replay, rangeStartTimestampMs, rangeEndTimestampMs}), | ||
| enabled: true, | ||
| gcTime: 0, // Infinity, |
There was a problem hiding this comment.
oops, had this set to 0 for testing because i didn't want the cache to kick in so often.
Bundle ReportChanges will increase total bundle size by 44.89kB (0.14%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
|
I was thinking about adding a feature-flag around this.. but it's pretty deep inside the workflow, so i think I might not 'need' it even if it's a good habit in all cases. Exception to the rule! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.