Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trust-policies chart with support for trust domain #59

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

codysoyland
Copy link
Contributor

@codysoyland codysoyland commented Sep 19, 2024

@codysoyland codysoyland requested review from steiza and a team as code owners September 19, 2024 15:03
ejahnGithub
ejahnGithub previously approved these changes Sep 19, 2024
Copy link

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Cody Soyland <[email protected]>
steiza
steiza previously approved these changes Sep 19, 2024
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor non-blocking Q's, LGTM!

# githubTrustDomain may be set to the trust domain applicable for some GitHub Enterprise Cloud accounts.
# If applicable, this may be set to the output of the following command:
# $ gh api meta | jq .domains.artifact_attestations.trust_domain
# See documentation for more details: https://docs.github.com/en/actions/security-for-github-actions/using-artifact-attestations/enforcing-artifact-attestations-with-a-kubernetes-admission-controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: I don't see any mention of trust domains on this documentation today - maybe it's getting updated later?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steiza separate PR

@@ -8,8 +8,8 @@ sources:
type: application

name: trust-policies
version: "v0.5.0"
appVersion: "v0.5.0"
version: "v0.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor / just to make sure I understand: we're making this tag after this pull request lands?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right!

Signed-off-by: Cody Soyland <[email protected]>
Copy link
Member

@steiza steiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setting that keeps dismissing reviews is quite annoying...

@codysoyland codysoyland merged commit 6ca9338 into main Sep 19, 2024
1 check passed
@codysoyland codysoyland deleted the trust-domain branch September 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants