Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch for #34710, improving caching credentials with oauth mention #34712

Closed
wants to merge 4 commits into from
Closed

Patch for #34710, improving caching credentials with oauth mention #34712

wants to merge 4 commits into from

Commits on Sep 24, 2024

  1. Improve caching-your-github-credentials-in-git.md based on my confusion 

    Adding section about other Git credential helpers, and mention OAuth.

This is based on my difficulties understanding how to get OAuth authentication from my local Git installation. The current content does not mention OAuth, or the need for organisation approval of OAuth apps not pre-approved by GitHub. Both those omissions caused obstacles for me. This is the content I wished I had at the time.
    @JDLH
    JDLH authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    23c513c View commit details
    Browse the repository at this point in the history

  2. Lint and style improvements to caching-your-github-credentials-in-git.md 

    Formatting changes to correct lint problems. Label a code fence as text. Remove docs.github.com from links to docs. Delete a traling space.

Turn a long sentence with two inline links into a 2-item list. This responds in part to "Writing for translation" style instructions.
    @JDLH
    JDLH authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bf3c239 View commit details
    Browse the repository at this point in the history

  3. Fix lint problems in caching-your-github-credentials-in-git.md 

    Removed spurious left square bracket in line 116, to attempt a fix to lint problem "MD029, ol-prefix Ordered list item prefix".

Shortened line 126, a text error message. It is now 64 characters. Still longer than the desired 60 characters, but I don't see how to make it 4 characters shorter and still keep the example understandable. So, I expect it will still get a lint warning.

Links on lines 115 and 116 are unchanged. The link checker seems to have a problem with them, and I don't know how to fix it.
    @JDLH
    JDLH authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    fab568c View commit details
    Browse the repository at this point in the history

  4. Fix OL numbering in caching-your-github-credentials-in-git.md 

    Fix a lint problem in line 116. Change number of second item in the ordered list from "2" to "1". I am guessing that every item in the list should be numbered "1".
    @JDLH
    JDLH authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    c9af082 View commit details
    Browse the repository at this point in the history