-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add maven package ecosystem detection #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this pull request! I appreciate the effort to expand the supported package ecosystems. I think it's a great idea to add support for maven! Can we add some test cases to cover this package manager so we can maintain confidence that future changes don't break this new functionality?
Thanks, I added a basic test case for maven package manager. If you have further test cases in mind please let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Awesome!! Thank you for adding maven to the package ecosystems supported!
Pull Request
Proposed Changes
Add support for maven package ecosystem to be detected by
pom.xml
file in root of repositories.Readiness Checklist
Author/Contributor
make lint
and fix any issues that you have introducedmake test
and ensure you have test coverage for the lines you are introducing@jeffrey-luszcz
Reviewer
fix
,documentation
,enhancement
,infrastructure
,maintenance
orbreaking