Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add maven package ecosystem detection #239

Merged
merged 7 commits into from
Oct 9, 2024

Conversation

jmrt47
Copy link
Contributor

@jmrt47 jmrt47 commented Oct 2, 2024

Pull Request

Proposed Changes

Add support for maven package ecosystem to be detected by pom.xml file in root of repositories.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing
  • If publishing new data to the public (scorecards, security scan results, code quality results, live dashboards, etc.), please request review from @jeffrey-luszcz

Reviewer

  • Label as either fix, documentation, enhancement, infrastructure, maintenance or breaking

Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this pull request! I appreciate the effort to expand the supported package ecosystems. I think it's a great idea to add support for maven! Can we add some test cases to cover this package manager so we can maintain confidence that future changes don't break this new functionality?

@jmrt47
Copy link
Contributor Author

jmrt47 commented Oct 5, 2024

Thanks for submitting this pull request! I appreciate the effort to expand the supported package ecosystems. I think it's a great idea to add support for maven! Can we add some test cases to cover this package manager so we can maintain confidence that future changes don't break this new functionality?

Thanks, I added a basic test case for maven package manager. If you have further test cases in mind please let me know.

@jmrt47 jmrt47 requested a review from zkoppert October 8, 2024 06:03
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Awesome!! Thank you for adding maven to the package ecosystems supported!

@zkoppert zkoppert merged commit 37e422d into github:main Oct 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants