Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description of the max-lag-millis in docs #1388

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

dontstopbelieveing
Copy link
Contributor

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: #1387

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR updates the docs for the description of the max-lag-millis command line parameter, specially in context of running on master

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@dontstopbelieveing dontstopbelieveing changed the title Update he description of the max-lag-millis in docs Update the description of the max-lag-millis in docs Mar 9, 2024
@dontstopbelieveing
Copy link
Contributor Author

@meiji163 @timvaillancourt @rashiq Can I please request a review?

Copy link
Collaborator

@timvaillancourt timvaillancourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dontstopbelieveing 🙏

@timvaillancourt timvaillancourt merged commit bc6cd55 into github:master Mar 12, 2024
7 checks passed
@ramshad-sha ramshad-sha mentioned this pull request Mar 25, 2024
Closed
@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants