Double the time waiting post replication restart #1421

andyedison · 2024-06-11T19:29:58Z

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue:

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR increases the startSlavePostWaitMilliseconds as we are seeing an error when running gh-ost in some cloud environments that the Slave_IO_Running is Connecting rather than Yes as expected.

We found this old PR that described the issue we're having #337 - as a first step we are increasing by doubling the value. If this test is successful, then we'll look into making this something that could be configured.

In case this PR introduced Go code changes:

contributed code is using same conventions as original code
script/cibuild returns with no formatting errors, build errors or unit test errors.

Co-authored-by: Tim Vaillancourt <[email protected]>

Signed-off-by: Tim Vaillancourt <[email protected]>

* WIP * Pass entire sql.UniqueKey * newline for limit * Rename var --------- Co-authored-by: meiji163 <[email protected]>

* Include git commit in version Signed-off-by: Tim Vaillancourt <[email protected]> * Make --version output change less-breaking --------- Signed-off-by: Tim Vaillancourt <[email protected]>

* Cleanup whitespace in SQL query text * cleanup * Add indent * Update unit tests * Update unit tests, pt 2 * Fix tweaks * Fix merge conflict resolution Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>

* Fix `--version` output Signed-off-by: Tim Vaillancourt <[email protected]> * Always fallback version/commit if undef Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>

* go1.21 + bullseye Signed-off-by: Tim Vaillancourt <[email protected]> * go1.21 + bullseye pt 2 Signed-off-by: Tim Vaillancourt <[email protected]> * checkout before setup-go Signed-off-by: Tim Vaillancourt <[email protected]> * go fmt Signed-off-by: Tim Vaillancourt <[email protected]> * Use golangci-lint 1.54.2 to support go1.21 Signed-off-by: Tim Vaillancourt <[email protected]> * stop using io/ioutil to make linter happy Signed-off-by: Tim Vaillancourt <[email protected]> * Fix typo Signed-off-by: Tim Vaillancourt <[email protected]> * Lint Signed-off-by: Tim Vaillancourt <[email protected]> * revert replica-tests CI to ubuntu 20 due to linker errors Signed-off-by: Tim Vaillancourt <[email protected]> * Update ensure-go-installed * use `ubuntu-latest` for `ci` job Signed-off-by: Tim Vaillancourt <[email protected]> * stretch -> bullseye Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Signed-off-by: Tim Vaillancourt <[email protected]>

Signed-off-by: Tim Vaillancourt <[email protected]>

Remove `@dm-2` as I am no longer a maintainer for gh-ost.

…1374)

Update CODEOWNERS

* Add cpu-profile interactive command * better doc markdown Signed-off-by: Tim Vaillancourt <[email protected]> * set block profile after isProfiling=1 Signed-off-by: Tim Vaillancourt <[email protected]> * improve test Signed-off-by: Tim Vaillancourt <[email protected]> * check isCPUProfiling later Signed-off-by: Tim Vaillancourt <[email protected]> * Cleanup Signed-off-by: Tim Vaillancourt <[email protected]> * Fix discrepancy Signed-off-by: Tim Vaillancourt <[email protected]> * move base64 to .applyServerCommand(...) Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: meiji163 <[email protected]>

* feat(feat-config-connection-charset): support config connection charset * feat(feat-config-connection-charset): feat-config-connection-charset The ability to specify character set and collation is supported. --------- Co-authored-by: shaohoukun <[email protected]>

Co-authored-by: meiji163 <[email protected]>

* Bump actions/upload-artifact from 1 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 1 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v1...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * update codeQL action --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: meiji163 <[email protected]>

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: meiji163 <[email protected]>

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v3...v4) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: meiji163 <[email protected]>

* fix(fix binlog end-log-pos over 4g lost data): fix binlog end-log-pos over 4g lost data * fix(fix-binlog-end-log-pos-over-lost-data): fix-binlog-end-log-pos-over-lost-data Calculate whether the binlog log_pos overflows beyond 4G using end_log_pos and event_size. * fix(x): x x * test(fix-binlog-end-log-pos-over-lost-data): add unit test * fix(fix-binlog-end-log-pos-over-lost-data): x x * Update binlog.go change IsLogPosOverflowBeyond4Bytes comment. * Update binlog.go x * fix(fix-binlog-end-log-pos-over-lost-data): fix doc x --------- Co-authored-by: shaohoukun <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]> Co-authored-by: meiji163 <[email protected]>

* Update description for max-lag-millis in command-line-flags.md * Update command-line-flags.md --------- Co-authored-by: Tim Vaillancourt <[email protected]>

Signed-off-by: Tim Vaillancourt <[email protected]>

* Update to go1.22, update core deps to latest-stable Signed-off-by: Tim Vaillancourt <[email protected]> * update script/ensure-go-installed Signed-off-by: Tim Vaillancourt <[email protected]> * git add vendor --all Signed-off-by: Tim Vaillancourt <[email protected]> * go 1.22.0 Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: meiji163 <[email protected]>

Signed-off-by: mountcount <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]>

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 6. - [Release notes](https://github.com/golangci/golangci-lint-action/releases) - [Commits](golangci/golangci-lint-action@v4...v6) --- updated-dependencies: - dependency-name: golangci/golangci-lint-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: overallteach <[email protected]>

andyedison · 2024-06-11T19:40:59Z

Targeted the wrong branch > will use #1422

Signed-off-by: Tim Vaillancourt <[email protected]>

…s, with timeout

testwill and others added 30 commits December 7, 2023 15:50

fix: typo (#1331)

fe9d8d1

Co-authored-by: Tim Vaillancourt <[email protected]>

Remove stale RELEASE_VERSION file (#1349)

fa12f44

Signed-off-by: Tim Vaillancourt <[email protected]>

Force index in unique key range queries (#1237)

b22229f

* WIP * Pass entire sql.UniqueKey * newline for limit * Rename var --------- Co-authored-by: meiji163 <[email protected]>

Include git commit in version (#1347)

d90112c

* Include git commit in version Signed-off-by: Tim Vaillancourt <[email protected]> * Make --version output change less-breaking --------- Signed-off-by: Tim Vaillancourt <[email protected]>

Fix tokens in inspector logging (#1226)

347d8e0

Fix --version output (#1352)

679d39e

* Fix `--version` output Signed-off-by: Tim Vaillancourt <[email protected]> * Always fallback version/commit if undef Signed-off-by: Tim Vaillancourt <[email protected]> --------- Signed-off-by: Tim Vaillancourt <[email protected]>

Replace deprecated github.com/satori/go.uuid lib (#1354)

8f9c384

Signed-off-by: Tim Vaillancourt <[email protected]>

Add CODEOWNERS file to auto-request reviews (#1350)

59fd18d

Signed-off-by: Tim Vaillancourt <[email protected]>

Fix successive failures error in streamer (#1371)

11d66d8

Update CODEOWNERS

51c1a21

Remove `@dm-2` as I am no longer a maintainer for gh-ost.

Print status to migration context logging after escaping % character (#…

a6cddf9

…1374)

Merge branch 'master' into update-codeowners

6f09ee0

Merge pull request #1375 from github/update-codeowners

3aa6912

Update CODEOWNERS

Add Dependabot config file (#1213)

17149b9

Co-authored-by: meiji163 <[email protected]>

Update pinned deps (#1355)

9ca2499

Signed-off-by: Tim Vaillancourt <[email protected]> Co-authored-by: meiji163 <[email protected]>

Update the description of the max-lag-millis in docs (#1388)

bc6cd55

* Update description for max-lag-millis in command-line-flags.md * Update command-line-flags.md --------- Co-authored-by: Tim Vaillancourt <[email protected]>

Add --mysql-wait-timeout flag (#1401)

c681f61

Add doc for PR #1401 (#1403)

329b13d

Signed-off-by: Tim Vaillancourt <[email protected]>

chore: fix function names in comment (#1405)

8d99e46

Signed-off-by: mountcount <[email protected]> Co-authored-by: Tim Vaillancourt <[email protected]>

chore: fix some function names (#1417)

59db6fa

Signed-off-by: overallteach <[email protected]>

Double the time waiting post replication restart

ef238ee

andyedison requested a review from meiji163 June 11, 2024 19:30

drogart approved these changes Jun 11, 2024

View reviewed changes

meiji163 approved these changes Jun 11, 2024

View reviewed changes

andyedison had a problem deploying to prod-ae-01 June 11, 2024 19:50 Failure

andyedison deployed to prod-ae-01 June 11, 2024 19:52 Active

timvaillancourt and others added 5 commits August 14, 2024 11:23

Ensure -attempt-instant-ddl respects -execute flag (#1440)

1e1fbcb

Refine wait_timeout override to be at cut-over only (#1406)

48cb9ab

Signed-off-by: Tim Vaillancourt <[email protected]>

Add logic to ensure replication has started instead of assuming it ha…

1e25e71

…s, with timeout

Revert unintended change

df7fba3

Merge branch 'master' into adjust-wait-post-repl-restart

ea5708e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Double the time waiting post replication restart #1421

Double the time waiting post replication restart #1421

andyedison commented Jun 11, 2024

andyedison commented Jun 11, 2024

Double the time waiting post replication restart #1421

Are you sure you want to change the base?

Double the time waiting post replication restart #1421

Conversation

andyedison commented Jun 11, 2024

A Pull Request should be associated with an Issue.

Description

andyedison commented Jun 11, 2024