Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display length of shortest path in MRVA UI #3671

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

p-
Copy link
Contributor

@p- p- commented Jul 24, 2024

Hey 👋

This PR implements my feature request from #3659.
I'm totally open for changes of course (e.g. visualize it differently etc. - e.g. use a callout displaying only the number with a tooltip for more information)

Note:

  • Due to the type definitions I assumed that the codeflows are available in the instances where this UI are displayed. (if not more checks would be warranted)
  • I've added a data-testid to assert the textcontent of the label on one line.

Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. I've left a couple of small suggestions.

Thank you for contributing!

extensions/ql-vscode/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@charisk charisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@charisk charisk merged commit 9c3b0b2 into github:main Jul 25, 2024
15 checks passed
@dbartol dbartol mentioned this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants