-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log/slog: export Source method in Record for custom handler support #70281
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 5c37e88) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626976. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/626976. |
Message from Ernesto Alejandro Santana: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626976. |
Message from Jonathan Amsterdam: Patch Set 2: Hold+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/626976. |
Currently, the `source` method in `slog.Record` is not accessible to custom handlers, requiring developers to re-implement logic for retrieving source location information. This commit exports the `source` method as `Source`, enabling consistent access for custom logging handlers and reducing code redundancy. Fixes golang#70280 Change-Id: I3eb3bc60658abc5de95697a10bddd11ab54c6e13 GitHub-Last-Rev: 5c37e88 GitHub-Pull-Request: golang#70281
This PR (HEAD: 9121c71) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626976. Important tips:
|
Currently, the
source
method inslog.Record
is not accessible tocustom handlers, requiring developers to re-implement logic for
retrieving source location information. This commit exports the
source
method as
Source
, enabling consistent access for custom logginghandlers and reducing code redundancy.
Fixes #70280