Add enum types valuemust be the same across source schemas #42
+67
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PascalSenn
commented
Aug 4, 2024
spec/Section 4 -- Composition.md
Outdated
| **Explanatory Text** | ||
|
|
||
| This rule ensures that enum types with the same name across different source schemas in a composite schema have identical sets of values. | ||
| Enums, must be consistent across source schemas to avoid conflicts and ambiguities in the composite schema. |
There was a problem hiding this comment.
At the moment enum value have to be strictly equal. We do not differentiate between output, input or combined enums
There was a problem hiding this comment.
At the moment enum value have to be strictly equal
Do we plan to explore relaxing this to allow evolution of enums?
There was a problem hiding this comment.
Yes we just talked about this in yesterdays wg, we are probably going to use the same pattern that federation uses currently.
union in ouput, intersection in input and exact match if used as in- and output
glen-84
suggested changes
Aug 5, 2024
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
|
Depending if the enum is uses only on the output, or only on the input or on both we have different handling of enums. |
glen-84
suggested changes
Nov 10, 2024
Co-authored-by: Glen <[email protected]>
Co-authored-by: Glen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.