Bump new major version of flow. #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nataliq
reviewed
Sep 26, 2019
There was a problem hiding this comment.
Please add some description to the PR. Maybe the upgrade notes as we did for the Form major release: iZettle/Form#130
It's also a good idea to post in the oss slack that you're preparing 2.0 release, maybe there are more things to include?
| @@ -1,6 +1,6 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = "FlowFramework" | |||
| s.version = "1.8.3" | |||
| s.version = "2.0.0" | |||
There was a problem hiding this comment.
The FlowTests plist should also be updated. Are you using agvtool?
| @@ -1,6 +1,10 @@ | |||
| # 2.0.0 | |||
|
|
|||
| - Remove custom Result type in favour of `Swift.Result` | |||
There was a problem hiding this comment.
Isn't there some code related to this to be removed in this PR? Some deprecations?
moglistree
force-pushed
the
master
branch
2 times, most recently
from
deccedd
to
65d4f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.