Address Scalings in Dolomite Conversion #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are scalings
m_emb, m_residual, m_width
that are part of Dolomite but not part of standard HF arch,So when performing
export_to_huggingface_llama
andimport_from_huggingface_llama
we need to account fro this calingm_emb, m_residual
but notm_width
the key idea is to absorb the constant into specific parts of the weights. But the dififculty with
m_width
is that the lm_head is tied.But this is a demo of how these match