Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new microcenters locations, more 4090 GPUs, fixed incorrect URLs #3181

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

rkozyak
Copy link
Contributor

@rkozyak rkozyak commented Sep 13, 2024

Description

Added two recently opened Microcenter stores:

  • Miami
  • Charlotte

Added several 4090 cards to Microcenter list:

  • ASUS 4090 Strix White OC
  • ASUS 4090 TUF Gaming OC
  • Gigabyte 4090 Xtreme Waterforce OC
  • Gigabyte 4090 AORUS Master OC
  • Gigabyte RTX 4090 Aero OC
  • Gigabyte Windforce V2 OC
  • MSI 4090 Gaming X Slim
  • PNY 4090 Verto

Added following GPU models:

  • vetro (xlr8 vetro was included before but not basic vetro)
  • windforce v2 (windforce v1 was included before but not the v2)
  • gaming x slim

Some Microcenter GPUs were missing the /?storeid= text from the URL so I added it to those URLs

Testing

Verified URLs are working
Made sure store IDs were for the correct location

Some were missing the /?storeid= so I added it to them
Included every non-discontinued model that was not already listed
@rkozyak rkozyak requested a review from jef as a code owner September 13, 2024 19:34
Copy link
Owner

@jef jef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for the contribution and updating <3

@jef jef changed the title Added some features relating to Microcenter. New locations, more 4090 GPUs, fixed incorrect URLs feat: add new microcenters locations, more 4090 GPUs, fixed incorrect URLs Sep 13, 2024
@jef jef merged commit 218b0c3 into jef:main Sep 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants