[JENKINS-73487] Fix Stapler exception with multiple security warnings #9983
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-73487. Amends #7046.
Testing done
I found this issue to be reproducible with Script Security 1.78 on 2.462.x (as well as latest master). My guess is it might happen once you collect multiple security warnings for an installed component, but looking at the code I'm unsure why that would be. Did not investigate further once I had the reproduction.
Adding this change / reverting it switches between the good and bad behaviors:
Proposed changelog entries
hudson.model.UpdateSite$Warning
on Manage Jenkins that may be shown when plugins with known security issues are installed.Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist