Blog Post for PR: Prototype a MQTT Source #7919 #6062
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ctmphuongg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
size/L
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you @ctmphuongg for composing up a blog post about the MQTT source! |
There was a problem hiding this comment.
I like the start @ctmphuongg !
But, I think we should be pointing at the released container images for the mqtt source instead of using ko to deploy it here (as that is really more for local development)
Unfortunately I can't seem to find the released container images in the knative-nightly images, not sure if @pierDipi knows how to get those included there...
| We will first need to build the Container Source using command: | ||
|
|
||
| ```shell | ||
| ko build cmd/mqttsource/main.go | ||
| ``` |
There was a problem hiding this comment.
Here, instead of using a local dev command, can we point users to a released image?
There was a problem hiding this comment.
Just resolved the other comments! However, I'm not too sure how I can get the released image here...
There was a problem hiding this comment.
https://github.com/knative/docs/blob/main/.github/workflows/knative-docs-image.yaml
We use the GitHub action to build and publish the image to Knative's release image registry.
There was a problem hiding this comment.
@Leo6Leo we need it in eventing, not docs sadly...
Would you be interested in looking into getting the job in eventing to build+publish the mqtt source image?
There was a problem hiding this comment.
To get the image built and released we need to add mqttsource to the list here (in Eventing) https://github.com/knative/eventing/blob/e4b6d6861c5b6b3696ec8d9ab82ec73e04e0a781/hack/generate-yamls.sh#L57
| template: | ||
| spec: | ||
| containers: | ||
| - image: ko://knative.dev/eventing/cmd/mqttsource |
There was a problem hiding this comment.
Same here, instead of using the ko image url, can we point them to an actual registry url?
knative-prow-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
size/M
Add description of the problem this PR on MQTT Source in Knative Eventing #7919