-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]:Added hover effect to Supporters Cards #414
Conversation
Welcome @coder12git! It looks like this is your first PR to kubeedge/website 🎉 |
Hey @fisherxu please review my PR. |
@@ -2,7 +2,7 @@ import React from "react"; | |||
import SectionContainer from "../sectionContainer"; | |||
import Translate from "@docusaurus/Translate"; | |||
import "./index.scss"; | |||
|
|||
import Link from "@docusaurus/Link"; | |||
const supportList = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coder12git Thank you for your contributions! I think adding a blank line here between import and following parts would make the format look better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coder12git Thank you for your contributions! I think adding a blank line here between import and following parts would make the format look better.
Done @Shelley-BaoYue
Also @Shelley-BaoYue I want to inform you that I am looking forwared to contribute to this issue - #347, under LFX Fall'23. I have already submitted my application for this. I would love to get involved with this project and make and look forward to making an amazing contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coder12git Please squash the commits to fix the failed DCO test, thanks.
Signed-off-by: Suruchi Kumari <[email protected]>
Signed-off-by: Suruchi Kumari <[email protected]>
Signed-off-by: Suruchi Kumari <[email protected]>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/assign @Shelley-BaoYue
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fisherxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Added hover effects to the Supporters cards on the website. This enhancement would improve the user experience and provide visual feedback when interacting with the cards.
Issue -> #412
Currently, the cards on the website do not exhibit any visual change when hovered over. This can make the user interface feel static and less engaging.
When a user hovers over a card, it would display a subtle hover effect to indicate interactivity. This would include changing the background color, and adding a border.
Loom.Message.-.21.August.2023.mp4
No changes.
By implementing this hover effect, we can enhance the user experience and make the website's interface more dynamic and engaging.